Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 812613004: ozone: Fix events_unittests build with use_xkbcommon==1 (Closed)

Created:
5 years, 11 months ago by robert.bradford
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Fix events_unittests build with use_xkbcommon==1 In r311421 a test was modified that called into XkbKeyboardLayoutEngine::ParseLayoutName but this function was not exposed in the header file. This change exposes this method in the header file and fixes the build. Original CL that introduced issue: https://codereview.chromium.org/848833002 BUG=None TEST=Compile of events_unittests completes Committed: https://crrev.com/60fa98054958c6d358360c96df2e162e729d5d7a Cr-Commit-Position: refs/heads/master@{#311523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 2 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
robert.bradford
I'm not sure why the bots didn't pick this up, but from inspection of the ...
5 years, 11 months ago (2015-01-14 16:01:46 UTC) #2
dnicoara
-rjkorege@ +spang@ and kpschoedel@
5 years, 11 months ago (2015-01-14 16:09:52 UTC) #4
kpschoedel
LGTM, thanks. I suspect there's no bot build with use_xkbcommon.
5 years, 11 months ago (2015-01-14 16:15:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812613004/1
5 years, 11 months ago (2015-01-14 16:21:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/35966)
5 years, 11 months ago (2015-01-14 16:27:47 UTC) #9
robert.bradford
On 2015/01/14 16:27:47, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-14 17:51:49 UTC) #10
spang
RS lgtm
5 years, 11 months ago (2015-01-14 18:26:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812613004/1
5 years, 11 months ago (2015-01-14 18:32:47 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 19:07:19 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 19:09:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60fa98054958c6d358360c96df2e162e729d5d7a
Cr-Commit-Position: refs/heads/master@{#311523}

Powered by Google App Engine
This is Rietveld 408576698