Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 812613003: WebRtc issue breaking Android downstream bots (Closed)

Created:
5 years, 11 months ago by dshwang
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRtc issue breaking Android downstream bots DCHECK(context_3d.gl) in sk_video_renderer.cc:429 is hitted because WebRTC assumes video frame of WebRTC is not accelerated. However, it's not true on Android. This CL accelerates WebRTC drawing on Canvas2D or WebGL. TEST=content_browsertests.WebRtcAecDumpBrowserTest/WebRtcBrowserTest, https://apprtc.appspot.com/r/85186517?debug=loopback BUG=447613 Committed: https://crrev.com/8b085a26e0e534a7b69603bf7bc0c5c608b98e3d Cr-Commit-Position: refs/heads/master@{#310821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/renderer/media/webmediaplayer_ms.cc View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
dshwang
@scherkus could you review?
5 years, 11 months ago (2015-01-09 17:55:31 UTC) #2
dshwang
I test content_browsertests on Nexus5 v5.0.1. > build/android/test_runner.py gtest -s content_browsertests --gtest_filter WebRtcBrowserTest*
5 years, 11 months ago (2015-01-09 18:11:41 UTC) #3
dshwang
@xhwang, could you review?
5 years, 11 months ago (2015-01-09 18:17:07 UTC) #5
DaleCurtis
lgtm
5 years, 11 months ago (2015-01-09 18:26:10 UTC) #7
dshwang
On 2015/01/09 18:26:10, DaleCurtis wrote: > lgtm Thank you for reviewing!
5 years, 11 months ago (2015-01-09 18:33:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812613003/1
5 years, 11 months ago (2015-01-09 18:34:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 19:37:46 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 19:39:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b085a26e0e534a7b69603bf7bc0c5c608b98e3d
Cr-Commit-Position: refs/heads/master@{#310821}

Powered by Google App Engine
This is Rietveld 408576698