Support tasks injection into a running VM.

include/v8-debug.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_V8_DEBUG_H_
 #define V8_V8_DEBUG_H_
 
 #include "v8.h"
 
 /**
@@ skipping 159 matching lines @@
   // Check if a debugger break is scheduled in the given isolate.
   static bool CheckDebugBreak(Isolate* isolate);
 
   // Break execution of JavaScript in the given isolate (this method
   // can be invoked from a non-VM thread) for further client command
   // execution on a VM thread. Client data is then passed in
   // EventDetails to EventCallback2 at the moment when the VM actually
   // stops.
   static void DebugBreakForCommand(Isolate* isolate, ClientData* data);
 
+  class Task {

[Sven Panne, 2014/12/18 08:27:50]

We already have v8::Task, why do we need another one?

In general, it's a pity that we can't use std::function yet.

[alph, 2014/12/18 14:28:03]

Sorry, missed the v8::Task.

+   public:
+    virtual void Run() = 0;
+    virtual ~Task() {}
+  };
+
+  // Break execution of JavaScript in the given isolate (this method
+  // can be invoked from a non-VM thread) and execute the given task on the
+  // VM thread. The VM takes ownership of the task.

[Sven Panne, 2014/12/18 08:27:51]

Please extend the comment a bit, describing that the task is run at most once
and deleted after that. Another thing which needs a description: If it is not
run, when exactly does it get destroyed?

[alph, 2014/12/18 14:28:03]

Done.

+  static void BreakAndRun(Isolate* isolate, Task* task);
+
   // Message based interface. The message protocol is JSON.
   static void SetMessageHandler(MessageHandler handler);
 
   static void SendCommand(Isolate* isolate,
                           const uint16_t* command, int length,
                           ClientData* client_data = NULL);
 
  /**
   * Run a JavaScript function in the debugger.
   * \param fun the function to call
@@ skipping 71 matching lines @@
 };
 
 
 }  // namespace v8
 
 
 #undef EXPORT
 
 
 #endif  // V8_V8_DEBUG_H_