Issue 812573005: Oilpan: fix build after r188071.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 812573005: Oilpan: fix build after r188071. (Closed)

Created:
5 years, 11 months ago by sof

Modified:
5 years, 11 months ago

Reviewers:
haraken, oilpan-reviews

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r188071. As ScriptWrappable doesn't have a virtual destructor with Oilpan enabled, declare ScriptWorkerClient as having a virtual destructor. Otherwise derived classes of it (ServiceWorkerWindowClient) cannot declare their destructor as an "override". TBR=oilpan-reviews,haraken BUG=447212 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188081