Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 812563002: More -fsanitize=vptr fixes. (Closed)

Created:
6 years ago by Sven Panne
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

More -fsanitize=vptr fixes. This actually fixes 3 different issues when accessing Operand1: * Object vs. HeapObject * Wrong defaults for equals/hash * silently dropping const TEST=test/mjsunit/regress/regress-441099.js BUG=chromium:441099 LOG=y Committed: https://crrev.com/cbf3b0bcc745536ee97ca21a3f9a7e613f31bc18 Cr-Commit-Position: refs/heads/master@{#25843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -10 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-441099.js View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
6 years ago (2014-12-16 12:45:33 UTC) #2
Benedikt Meurer
Urgs...LGTM
6 years ago (2014-12-16 13:01:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812563002/1
6 years ago (2014-12-16 13:01:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 14:20:23 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-17 10:14:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbf3b0bcc745536ee97ca21a3f9a7e613f31bc18
Cr-Commit-Position: refs/heads/master@{#25843}

Powered by Google App Engine
This is Rietveld 408576698