Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 812553004: Tidy string16.h after https://codereview.chromium.org/809563003/ (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : parallel location for string16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M base/strings/string16.h View 1 2 3 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
6 years ago (2014-12-16 17:32:28 UTC) #1
Mark Mentovai
LGTM with this one more refinement, too. Thanks for following up. https://codereview.chromium.org/812553004/diff/20001/base/strings/string16.h File base/strings/string16.h (right): ...
6 years ago (2014-12-16 18:34:07 UTC) #2
scottmg
https://codereview.chromium.org/812553004/diff/20001/base/strings/string16.h File base/strings/string16.h (right): https://codereview.chromium.org/812553004/diff/20001/base/strings/string16.h#newcode19 base/strings/string16.h:19: typedef std::wstring string16; On 2014/12/16 18:34:07, Mark Mentovai wrote: ...
6 years ago (2014-12-16 18:56:39 UTC) #3
scottmg
6 years ago (2014-12-16 18:57:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e87cd9d4dff52a0bd77f8473002bed48f0f3df2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698