Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 812553003: Move virtual setSurfaceReady to non-virtual StartCompositor. (Closed)

Created:
6 years ago by danakj
Modified:
6 years ago
Reviewers:
jamesr, no sievers, jbauman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, piman+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move virtual setSurfaceReady to non-virtual StartCompositor. This method is no longer part of the blink APIs that RenderWidgetCompositor implements, so make it non-virtual and follow chromium style. Committed: https://crrev.com/018271e37da4447f89ac0c8cdc24cf967eb78407 Cr-Commit-Position: refs/heads/master@{#308668}

Patch Set 1 #

Patch Set 2 : setSurfaceReady: rebase #

Patch Set 3 : setSurfaceReady: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M content/renderer/gpu/render_widget_compositor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
danakj
https://codereview.chromium.org/801063002/ was the blink side
6 years ago (2014-12-16 17:02:50 UTC) #1
danakj
+jbauman
6 years ago (2014-12-16 17:03:00 UTC) #3
danakj
Oh, I need a content/ owner. +sievers
6 years ago (2014-12-16 17:03:30 UTC) #5
danakj
Removed other overrides of setSurfaceReady, they're dead code. +jamesr for mojo/
6 years ago (2014-12-16 19:26:52 UTC) #7
no sievers
lgtm
6 years ago (2014-12-16 19:31:04 UTC) #8
jamesr
lgtm
6 years ago (2014-12-16 20:41:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812553003/40001
6 years ago (2014-12-16 21:13:23 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-16 21:17:34 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-16 21:19:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/018271e37da4447f89ac0c8cdc24cf967eb78407
Cr-Commit-Position: refs/heads/master@{#308668}

Powered by Google App Engine
This is Rietveld 408576698