Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: cc/trees/layer_tree_host_unittest_picture.cc

Issue 812543002: Update from https://crrev.com/308331 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_unittest_no_message_loop.cc ('k') | cc/trees/single_thread_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_picture.cc
diff --git a/cc/trees/layer_tree_host_unittest_picture.cc b/cc/trees/layer_tree_host_unittest_picture.cc
index 2d485b40f50c54de6d34f3a9c1df2ec67865d314..773798acf9bdbb9828eaf7f0404b4bb5d77c2b15 100644
--- a/cc/trees/layer_tree_host_unittest_picture.cc
+++ b/cc/trees/layer_tree_host_unittest_picture.cc
@@ -16,20 +16,25 @@ namespace {
// These tests deal with picture layers.
class LayerTreeHostPictureTest : public LayerTreeTest {
protected:
- void InitializeSettings(LayerTreeSettings* settings) override {
- // PictureLayer can only be used with impl side painting enabled.
- settings->impl_side_painting = true;
+ void SetupTreeWithSinglePictureLayer(const gfx::Size& size) {
+ scoped_refptr<Layer> root = Layer::Create();
+ root->SetBounds(size);
+
+ root_picture_layer_ = FakePictureLayer::Create(&client_);
+ root_picture_layer_->SetBounds(size);
+ root->AddChild(root_picture_layer_);
+
+ layer_tree_host()->SetRootLayer(root);
}
+
+ scoped_refptr<FakePictureLayer> root_picture_layer_;
+ FakeContentLayerClient client_;
};
class LayerTreeHostPictureTestTwinLayer
: public LayerTreeHostPictureTest {
void SetupTree() override {
- LayerTreeHostPictureTest::SetupTree();
-
- scoped_refptr<FakePictureLayer> picture =
- FakePictureLayer::Create(&client_);
- layer_tree_host()->root_layer()->AddChild(picture);
+ SetupTreeWithSinglePictureLayer(gfx::Size(1, 1));
}
void BeginTest() override {
@@ -117,11 +122,200 @@ class LayerTreeHostPictureTestTwinLayer
void AfterTest() override {}
- FakeContentLayerClient client_;
int activates_;
};
-MULTI_THREAD_TEST_F(LayerTreeHostPictureTestTwinLayer);
+SINGLE_AND_MULTI_THREAD_IMPL_TEST_F(LayerTreeHostPictureTestTwinLayer);
+
+class LayerTreeHostPictureTestResizeViewportWithGpuRaster
+ : public LayerTreeHostPictureTest {
+ void InitializeSettings(LayerTreeSettings* settings) override {
+ settings->gpu_rasterization_forced = true;
+ }
+
+ void SetupTree() override {
+ scoped_refptr<Layer> root = Layer::Create();
+ root->SetBounds(gfx::Size(768, 960));
+
+ client_.set_fill_with_nonsolid_color(true);
+ picture_ = FakePictureLayer::Create(&client_);
+ picture_->SetBounds(gfx::Size(768, 960));
+ root->AddChild(picture_);
+
+ layer_tree_host()->SetRootLayer(root);
+ LayerTreeHostPictureTest::SetupTree();
+ }
+
+ void BeginTest() override { PostSetNeedsCommitToMainThread(); }
+
+ void WillActivateTreeOnThread(LayerTreeHostImpl* impl) override {
+ LayerImpl* child = impl->sync_tree()->root_layer()->children()[0];
+ FakePictureLayerImpl* picture_impl =
+ static_cast<FakePictureLayerImpl*>(child);
+ gfx::Size tile_size =
+ picture_impl->HighResTiling()->TileAt(0, 0)->content_rect().size();
+
+ switch (impl->sync_tree()->source_frame_number()) {
+ case 0:
+ tile_size_ = tile_size;
+ // GPU Raster picks a tile size based on the viewport size.
+ EXPECT_EQ(gfx::Size(768, 256), tile_size);
+ break;
+ case 1:
+ // When the viewport changed size, the new frame's tiles should change
+ // along with it.
+ EXPECT_NE(gfx::Size(768, 256), tile_size);
+ }
+ }
+
+ void DidCommit() override {
+ switch (layer_tree_host()->source_frame_number()) {
+ case 1:
+ // Change the picture layer's size along with the viewport, so it will
+ // consider picking a new tile size.
+ picture_->SetBounds(gfx::Size(768, 1056));
+ layer_tree_host()->SetViewportSize(gfx::Size(768, 1056));
+ break;
+ case 2:
+ EndTest();
+ }
+ }
+
+ void AfterTest() override {}
+
+ gfx::Size tile_size_;
+ FakeContentLayerClient client_;
+ scoped_refptr<FakePictureLayer> picture_;
+};
+
+SINGLE_AND_MULTI_THREAD_IMPL_TEST_F(
+ LayerTreeHostPictureTestResizeViewportWithGpuRaster);
+
+class LayerTreeHostPictureTestChangeLiveTilesRectWithRecycleTree
+ : public LayerTreeHostPictureTest {
+ void SetupTree() override {
+ frame_ = 0;
+ did_post_commit_ = false;
+
+ scoped_refptr<Layer> root = Layer::Create();
+ root->SetBounds(gfx::Size(100, 100));
+
+ // The layer is big enough that the live tiles rect won't cover the full
+ // layer.
+ client_.set_fill_with_nonsolid_color(true);
+ picture_ = FakePictureLayer::Create(&client_);
+ picture_->SetBounds(gfx::Size(100, 100000));
+ root->AddChild(picture_);
+
+ layer_tree_host()->SetRootLayer(root);
+ LayerTreeHostPictureTest::SetupTree();
+ }
+
+ void BeginTest() override { PostSetNeedsCommitToMainThread(); }
+
+ void DrawLayersOnThread(LayerTreeHostImpl* impl) override {
+ LayerImpl* child = impl->active_tree()->root_layer()->children()[0];
+ FakePictureLayerImpl* picture_impl =
+ static_cast<FakePictureLayerImpl*>(child);
+ FakePictureLayerImpl* recycled_impl = static_cast<FakePictureLayerImpl*>(
+ picture_impl->GetRecycledTwinLayer());
+
+ switch (++frame_) {
+ case 1: {
+ PictureLayerTiling* tiling = picture_impl->HighResTiling();
+ PictureLayerTiling* recycled_tiling = recycled_impl->HighResTiling();
+ int num_tiles_y = tiling->TilingDataForTesting().num_tiles_y();
+
+ // There should be tiles at the top of the picture layer but not at the
+ // bottom.
+ EXPECT_TRUE(tiling->TileAt(0, 0));
+ EXPECT_FALSE(tiling->TileAt(0, num_tiles_y));
+
+ // The recycled tiling matches it.
+ EXPECT_TRUE(recycled_tiling->TileAt(0, 0));
+ EXPECT_FALSE(recycled_tiling->TileAt(0, num_tiles_y));
+
+ // The live tiles rect matches on the recycled tree.
+ EXPECT_EQ(tiling->live_tiles_rect(),
+ recycled_tiling->live_tiles_rect());
+
+ // Make the bottom of the layer visible.
+ picture_impl->SetPosition(gfx::PointF(0.f, -100000.f + 100.f));
+ impl->SetNeedsRedraw();
+ break;
+ }
+ case 2: {
+ PictureLayerTiling* tiling = picture_impl->HighResTiling();
+ PictureLayerTiling* recycled_tiling = recycled_impl->HighResTiling();
+
+ // There not be tiles at the top of the layer now.
+ EXPECT_FALSE(tiling->TileAt(0, 0));
+
+ // The recycled twin tiling should not have unshared tiles at the top
+ // either.
+ EXPECT_FALSE(recycled_tiling->TileAt(0, 0));
+
+ // The live tiles rect matches on the recycled tree.
+ EXPECT_EQ(tiling->live_tiles_rect(),
+ recycled_tiling->live_tiles_rect());
+
+ // Make the top of the layer visible again.
+ picture_impl->SetPosition(gfx::PointF());
+ impl->SetNeedsRedraw();
+ break;
+ }
+ case 3: {
+ PictureLayerTiling* tiling = picture_impl->HighResTiling();
+ PictureLayerTiling* recycled_tiling = recycled_impl->HighResTiling();
+ int num_tiles_y = tiling->TilingDataForTesting().num_tiles_y();
+
+ // There should be tiles at the top of the picture layer again.
+ EXPECT_TRUE(tiling->TileAt(0, 0));
+ EXPECT_FALSE(tiling->TileAt(0, num_tiles_y));
+
+ // The recycled tiling should also have tiles at the top.
+ EXPECT_TRUE(recycled_tiling->TileAt(0, 0));
+ EXPECT_FALSE(recycled_tiling->TileAt(0, num_tiles_y));
+
+ // The live tiles rect matches on the recycled tree.
+ EXPECT_EQ(tiling->live_tiles_rect(),
+ recycled_tiling->live_tiles_rect());
+
+ // Make a new main frame without changing the picture layer at all, so
+ // it won't need to update or push properties.
+ did_post_commit_ = true;
+ PostSetNeedsCommitToMainThread();
+ break;
+ }
+ }
+ }
+
+ void WillActivateTreeOnThread(LayerTreeHostImpl* impl) override {
+ LayerImpl* child = impl->sync_tree()->root_layer()->children()[0];
+ FakePictureLayerImpl* picture_impl =
+ static_cast<FakePictureLayerImpl*>(child);
+ PictureLayerTiling* tiling = picture_impl->HighResTiling();
+ int num_tiles_y = tiling->TilingDataForTesting().num_tiles_y();
+
+ // The pending layer should always have tiles at the top of it each commit.
+ // The tile is part of the required for activation set so it should exist.
+ EXPECT_TRUE(tiling->TileAt(0, 0));
+ EXPECT_FALSE(tiling->TileAt(0, num_tiles_y));
+
+ if (did_post_commit_)
+ EndTest();
+ }
+
+ void AfterTest() override {}
+
+ int frame_;
+ bool did_post_commit_;
+ FakeContentLayerClient client_;
+ scoped_refptr<FakePictureLayer> picture_;
+};
+
+SINGLE_AND_MULTI_THREAD_IMPL_TEST_F(
+ LayerTreeHostPictureTestChangeLiveTilesRectWithRecycleTree);
} // namespace
} // namespace cc
« no previous file with comments | « cc/trees/layer_tree_host_unittest_no_message_loop.cc ('k') | cc/trees/single_thread_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698