Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3869)

Unified Diff: cc/debug/rasterize_and_record_benchmark_impl.cc

Issue 812543002: Update from https://crrev.com/308331 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/cc_tests.gyp ('k') | cc/layers/layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/rasterize_and_record_benchmark_impl.cc
diff --git a/cc/debug/rasterize_and_record_benchmark_impl.cc b/cc/debug/rasterize_and_record_benchmark_impl.cc
index c00d0b94dfefaa61be81c9e19af43012c6ca38be..03267a8e04b3244e0183e88ba0d155fe1ceb5163 100644
--- a/cc/debug/rasterize_and_record_benchmark_impl.cc
+++ b/cc/debug/rasterize_and_record_benchmark_impl.cc
@@ -15,6 +15,7 @@
#include "cc/resources/tile_task_worker_pool.h"
#include "cc/trees/layer_tree_host_common.h"
#include "cc/trees/layer_tree_host_impl.h"
+#include "cc/trees/layer_tree_impl.h"
#include "ui/gfx/geometry/rect.h"
namespace cc {
@@ -121,18 +122,6 @@ class FixedInvalidationPictureLayerTilingClient
return base_client_->GetMaxTilePriorityBin();
}
- size_t GetMaxTilesForInterestArea() const override {
- return base_client_->GetMaxTilesForInterestArea();
- }
-
- float GetSkewportTargetTimeInSeconds() const override {
- return base_client_->GetSkewportTargetTimeInSeconds();
- }
-
- int GetSkewportExtrapolationLimitInContentPixels() const override {
- return base_client_->GetSkewportExtrapolationLimitInContentPixels();
- }
-
WhichTree GetTree() const override { return base_client_->GetTree(); }
bool RequiresHighResToDraw() const override {
@@ -215,7 +204,15 @@ void RasterizeAndRecordBenchmarkImpl::RunOnLayer(PictureLayerImpl* layer) {
FixedInvalidationPictureLayerTilingClient client(
layer, gfx::Rect(layer->content_bounds()));
- auto tiling_set = PictureLayerTilingSet::Create(&client);
+
+ // In this benchmark, we will create a local tiling set and measure how long
+ // it takes to rasterize content. As such, the actual settings used here don't
+ // really matter.
+ const LayerTreeSettings& settings = layer->layer_tree_impl()->settings();
+ auto tiling_set = PictureLayerTilingSet::Create(
+ &client, settings.max_tiles_for_interest_area,
+ settings.skewport_target_time_in_seconds,
+ settings.skewport_extrapolation_limit_in_content_pixels);
PictureLayerTiling* tiling =
tiling_set->AddTiling(layer->contents_scale_x(), layer->bounds());
« no previous file with comments | « cc/cc_tests.gyp ('k') | cc/layers/layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698