Change signature of lookupConstructor to only require a name.

pkg/compiler/lib/src/js_backend/backend.dart

Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index a60666070a0cf83438a3abc8167e44f6a4fd6da8..183961a4a1ba5b1697e1341d7ddd85dcb6a30246 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -851,15 +851,16 @@ class JavaScriptBackend extends Backend {
           // The constructor is on the patch class, but dart2js unit tests don't
           // have a patch class.
           ClassElement implementation = cls.patch != null ? cls.patch : cls;
-          return implementation.lookupConstructor(
-            new Selector.callConstructor(
-                name, mapLiteralClass.library, arity),
-            (element) {
-              compiler.internalError(mapLiteralClass,
-                  "Map literal class $mapLiteralClass missing "
-                  "'$name' constructor"
-                  "  ${mapLiteralClass.constructors}");
-            });
+          Selector selector = new Selector.callConstructor(name,
+              mapLiteralClass.library, arity);
+          return implementation.validateConstructorLookupResults(selector,

[Johnni Winther, 2015/01/08 09:47:44]

Remove [Element.validateConstructorLookupResults] and
[BaseElement.validateConstructorLookupResults] and inline the check here.

Remember to update modely.dart in pkg/analyzer2dart when change elements.dart

[herhut, 2015/01/22 10:33:20]

Done.

+              implementation.lookupConstructor(name),
+              (element) {
+                compiler.internalError(mapLiteralClass,
+                    "Map literal class $mapLiteralClass missing "
+                    "'$name' constructor"
+                    "  ${mapLiteralClass.constructors}");
+              });
         }
         mapLiteralConstructor = getFactory('_literal', 1);
         mapLiteralConstructorEmpty = getFactory('_empty', 0);