Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 812503003: replace COMPILE_ASSERT with static_assert in chrome/common/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in chrome/common/ BUG=442514 Committed: https://crrev.com/07b849f08f82d3e351d28939a827543b89d603fd Cr-Commit-Position: refs/heads/master@{#309974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M chrome/common/crash_keys.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/webstore/webstore_api_constants.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/mac/launchd.mm View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/common/mac/mock_launchd.cc View 5 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Lei Zhang: PTAL
6 years ago (2014-12-23 00:58:42 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-05 21:38:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812503003/1
5 years, 11 months ago (2015-01-05 21:39:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-05 22:52:18 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 22:53:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b849f08f82d3e351d28939a827543b89d603fd
Cr-Commit-Position: refs/heads/master@{#309974}

Powered by Google App Engine
This is Rietveld 408576698