src/ic/ic-compiler.cc - Issue 812353002: Use weak cell to embed map in CompareNil IC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic-compiler.cc

Issue 812353002: Use weak cell to embed map in CompareNil IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic-compiler.cc

diff --git a/src/ic/ic-compiler.cc b/src/ic/ic-compiler.cc

index 69d707b03554ff3ecf66e41cec8f812ef8109881..3a1731268fc2ad1ae807cb7e8a899d6c49c4abb8 100644

--- a/src/ic/ic-compiler.cc

+++ b/src/ic/ic-compiler.cc

@@ -244,7 +244,8 @@ Handle<Code> PropertyICCompiler::ComputeCompareNil(Handle<Map> receiver_map,

}

Code::FindAndReplacePattern pattern;

- pattern.Add(isolate->factory()->meta_map(), receiver_map);

+ Handle<WeakCell> cell = Map::WeakCellForMap(receiver_map);

+ pattern.Add(isolate->factory()->meta_map(), cell);

Handle<Code> ic = stub->GetCodeCopy(pattern);

if (!receiver_map->is_dictionary_map()) {

« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/objects.cc » ('j') | no next file with comments »