src/code-stubs-hydrogen.cc - Issue 812353002: Use weak cell to embed map in CompareNil IC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs-hydrogen.cc

Issue 812353002: Use weak cell to embed map in CompareNil IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs-hydrogen.cc

diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc

index 0ede93b4de9f0d68fa4dc22ca38c5cd09e9ff10a..3b5002b7ff6a97adc5ddb62c76a1b13a40f14e08 100644

--- a/src/code-stubs-hydrogen.cc

+++ b/src/code-stubs-hydrogen.cc

@@ -1102,7 +1102,7 @@ HValue* CodeStubGraphBuilder<CompareNilICStub>::BuildCodeInitializedStub() {

HIfContinuation continuation;

Handle<Map> sentinel_map(isolate->heap()->meta_map());

Type* type = stub->GetType(zone(), sentinel_map);

- BuildCompareNil(GetParameter(0), type, &continuation);

+ BuildCompareNil(GetParameter(0), type, &continuation, kEmbedMapsViaWeakCells);

IfBuilder if_nil(this, &continuation);

if_nil.Then();

if (continuation.IsFalseReachable()) {

« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | no next file with comments »