src/hydrogen.h - Issue 812353002: Use weak cell to embed map in CompareNil IC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.h

Issue 812353002: Use weak cell to embed map in CompareNil IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.h

diff --git a/src/hydrogen.h b/src/hydrogen.h

index af7671b38bad3b40b1d649d61186e4a57bfdcfd3..c1ed797c96f0a37cca3c929d42852bcc1a91bbf7 100644

--- a/src/hydrogen.h

+++ b/src/hydrogen.h

@@ -1864,10 +1864,10 @@ class HGraphBuilder {

HValue* BuildElementIndexHash(HValue* index);

- void BuildCompareNil(

- HValue* value,

- Type* type,

- HIfContinuation* continuation);

+ enum MapEmbedding { kEmbedMapsDirectly, kEmbedMapsViaWeakCells };

+ void BuildCompareNil(HValue* value, Type* type, HIfContinuation* continuation,

+ MapEmbedding map_embedding = kEmbedMapsDirectly);

void BuildCreateAllocationMemento(HValue* previous_object,

HValue* previous_object_size,