Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 812173002: Make elementFromPoint() arguments non-optional (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
hayato
CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make elementFromPoint() arguments non-optional http://dev.w3.org/csswg/cssom-view/#extensions-to-the-document-interface http://w3c.github.io/webcomponents/spec/shadow/#the-shadowroot-interface Document.elementFromPoint() throws with too few arguments in Firefox Nightly and IE11, making this likely Web compatibly. ShadowRoot.elementFromPoint() has only been shipped in Blink, so stuff could break, but it does not seem likely enough to warrant use counters. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M LayoutTests/fast/dom/Document/missing-arguments.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Document/missing-arguments-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/elementfrompoint.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/elementfrompoint-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years ago (2014-12-17 23:27:10 UTC) #2
hayato
LGTM I agree that it does not seem likely enough to warrant use counters.
6 years ago (2014-12-18 05:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812173002/1
6 years ago (2014-12-18 06:52:05 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-18 09:17:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187443

Powered by Google App Engine
This is Rietveld 408576698