Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: src/preparser.cc

Issue 812163003: Simplify scanner and generate better error message for legacy octals in templates (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase it Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/preparser.h ('k') | src/scanner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/preparser.cc
diff --git a/src/preparser.cc b/src/preparser.cc
index 1bd33409f002d3d1711c14557fdbdf9ed2b11c98..b5526767539e0795533024198516ddb6dc8af760 100644
--- a/src/preparser.cc
+++ b/src/preparser.cc
@@ -125,7 +125,7 @@ PreParser::PreParseResult PreParser::PreParseLazyFunction(
DCHECK_EQ(Token::RBRACE, scanner()->peek());
if (scope_->strict_mode() == STRICT) {
int end_pos = scanner()->location().end_pos;
- CheckOctalLiteral(start_position, end_pos, &ok);
+ CheckStrictOctalLiteral(start_position, end_pos, &ok);
}
}
return kPreParseSuccess;
@@ -937,7 +937,7 @@ PreParser::Expression PreParser::ParseFunctionLiteral(
}
int end_position = scanner()->location().end_pos;
- CheckOctalLiteral(start_position, end_position, CHECK_OK);
+ CheckStrictOctalLiteral(start_position, end_position, CHECK_OK);
}
return Expression::Default();
« no previous file with comments | « src/preparser.h ('k') | src/scanner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698