Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: test/mjsunit/harmony/templates.js

Issue 812163003: Simplify scanner and generate better error message for legacy octals in templates (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase it Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/scanner.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --harmony-templates --harmony-unicode 5 // Flags: --harmony-templates --harmony-unicode
6 6
7 var num = 5; 7 var num = 5;
8 var str = "str"; 8 var str = "str";
9 function fn() { return "result"; } 9 function fn() { return "result"; }
10 var obj = { 10 var obj = {
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 469
470 { 470 {
471 // block 471 // block
472 }`jkl`; 472 }`jkl`;
473 })(); 473 })();
474 474
475 475
476 (function testLegacyOctal() { 476 (function testLegacyOctal() {
477 assertEquals('\u0000', `\0`); 477 assertEquals('\u0000', `\0`);
478 assertEquals('\u0000a', `\0a`); 478 assertEquals('\u0000a', `\0a`);
479 for (var i = 0; i < 10; i++) { 479 for (var i = 0; i < 8; i++) {
480 var code = "`\\0" + i + "`"; 480 var code = "`\\0" + i + "`";
481 assertThrows(code, SyntaxError); 481 assertThrows(code, SyntaxError);
482 code = "(function(){})" + code;
483 assertThrows(code, SyntaxError);
482 } 484 }
483 485
484 assertEquals('\\0', String.raw`\0`); 486 assertEquals('\\0', String.raw`\0`);
485 })(); 487 })();
486 488
487 489
488 (function testSyntaxErrorsNonEscapeCharacter() { 490 (function testSyntaxErrorsNonEscapeCharacter() {
489 assertThrows("`\\x`", SyntaxError); 491 assertThrows("`\\x`", SyntaxError);
490 assertThrows("`\\u`", SyntaxError); 492 assertThrows("`\\u`", SyntaxError);
491 for (var i = 1; i < 10; i++) { 493 for (var i = 1; i < 8; i++) {
492 var code = "`\\" + i + "`"; 494 var code = "`\\" + i + "`";
493 assertThrows(code, SyntaxError); 495 assertThrows(code, SyntaxError);
496 code = "(function(){})" + code;
497 assertThrows(code, SyntaxError);
494 } 498 }
495 })(); 499 })();
500
501
502 (function testValidNumericEscapes() {
503 assertEquals("8", `\8`);
504 assertEquals("9", `\9`);
505 assertEquals("\u00008", `\08`);
506 assertEquals("\u00009", `\09`);
507 })();
OLDNEW
« no previous file with comments | « src/scanner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698