Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 812163002: modifying blur gms to test with shader too (Closed)

Created:
6 years ago by joshua.litt
Modified:
6 years ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vm-off-drawstate
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

I could create new GMs if you prefer. BUG=skia: Committed: https://skia.googlesource.com/skia/+/341400ea7ba0f711ac4c6ead0b33c5c89b4ac55c

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : nogpu #

Patch Set 4 : whoops #

Patch Set 5 : rebase on master #

Patch Set 6 : fixing flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -17 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M gm/blurrect.cpp View 1 2 3 4 5 4 chunks +35 lines, -3 lines 0 comments Download
M gm/blurroundrect.cpp View 1 2 3 4 5 3 chunks +52 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
joshualitt
6 years ago (2014-12-17 23:01:50 UTC) #3
bsalomon
lgtm
6 years ago (2014-12-18 13:15:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812163002/80001
6 years ago (2014-12-18 17:00:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1259)
6 years ago (2014-12-18 17:06:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812163002/100001
6 years ago (2014-12-18 19:50:19 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-18 19:54:19 UTC) #11
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/341400ea7ba0f711ac4c6ead0b33c5c89b4ac55c

Powered by Google App Engine
This is Rietveld 408576698