Demangle names before using them as properties for DartHandleProxies.

Source/bindings/dart/DartHandleProxy.cpp

Index: Source/bindings/dart/DartHandleProxy.cpp
diff --git a/Source/bindings/dart/DartHandleProxy.cpp b/Source/bindings/dart/DartHandleProxy.cpp
index fe0bf72642fb2cb4babb6966192152fd6eb201df..fa0dafbac8f1a719ee6168c8ba36fafa4b889f4a 100644
--- a/Source/bindings/dart/DartHandleProxy.cpp
+++ b/Source/bindings/dart/DartHandleProxy.cpp
@@ -139,6 +139,11 @@ Dart_Handle addTrailingDot(Dart_Handle str)
     return DartUtilities::invokeUtilsMethod("addTrailingDot", 1, &str);
 }
 
+Dart_Handle demangle(Dart_Handle str)
+{
+    return DartUtilities::invokeUtilsMethod("demangle", 1, &str);
+}
+
 Dart_Handle lookupValueForEncodedMapKey(Dart_Handle object, Dart_Handle key)
 {
     Dart_Handle args[] = {object, key};
@@ -228,6 +233,7 @@ void addFunctionNames(Dart_Handle handle, v8::Local<v8::Array>& properties, intp
         if (isConstructor)
             functionName = stripClassName(functionName, Dart_TypeName(handle));
 

[Jacob, 2013/11/21 22:45:40]

this is never getting called and would likely do the wrong thing if it was
called. See the fixme above that the DartVM doesn't correctly handle invoking
properties with private names.

[rmacnak, 2013/11/21 23:14:20]

What is it the VM does incorrectly? Nothing seems to go wrong if I remove the
skip condition above.

+        functionName = demangle(functionName);
         properties->Set(*count, V8Converter::stringToV8(functionName));
         *count = *count + 1;
     }
@@ -255,7 +261,7 @@ void addFieldNames(Dart_Handle fieldNames, v8::Local<v8::Array>& properties, int
     Dart_ListLength(fieldNames, &length);
     for (intptr_t i = 0; i < length; i += 2) {
         Dart_Handle fieldName = Dart_ListGetAt(fieldNames, i);
-        properties->Set(*count, V8Converter::stringToV8(fieldName));
+        properties->Set(*count, V8Converter::stringToV8(demangle(fieldName)));

[Jacob, 2013/11/21 22:45:40]

do private fields in libraries show up correctly with this change or are all
their values "undefined"
please explore a library in the private field to the devtools to verify.

[rmacnak, 2013/11/21 23:14:20]

I can see the value in the Scope Variables section.

Curiously, instance fields still have their mangling.

         *count = *count + 1;
     }
 }
@@ -553,7 +559,7 @@ static void libraryPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>&
             if (!Dart_IsNull(importPrefix)) {
                 ASSERT(Dart_IsString(importPrefix));
                 properties->Set(count, V8Converter::stringToV8(
-                    stripTrailingDot(importPrefix)));
+                    demangle(stripTrailingDot(importPrefix))));
                 count++;
             }
             bool equals = false;