Demangle names before using them as properties for DartHandleProxies.

Demangle names before using them as properties for DartHandleProxies.

BUG=http://dartbug.com/14982
R=asiva@google.com, jacobr@google.com, vsm@google.com

Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=1619

[rmacnak, 2013-11-21 22:04:12]

Goes with https://codereview.chromium.org/79023010/

[vsm, 2013-11-21 22:27:33]

lgtm

[Jacob, 2013-11-21 22:45:40]

https://codereview.chromium.org/81213004/diff/90001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartHandleProxy.cpp (right):

https://codereview.chromium.org/81213004/diff/90001/Source/bindings/dart/Dart...
Source/bindings/dart/DartHandleProxy.cpp:235: 
this is never getting called and would likely do the wrong thing if it was
called. See the fixme above that the DartVM doesn't correctly handle invoking
properties with private names.

https://codereview.chromium.org/81213004/diff/90001/Source/bindings/dart/Dart...
Source/bindings/dart/DartHandleProxy.cpp:264: properties->Set(*count,
V8Converter::stringToV8(demangle(fieldName)));
do private fields in libraries show up correctly with this change or are all
their values "undefined"
please explore a library in the private field to the devtools to verify.

[rmacnak, 2013-11-21 23:14:20]

https://codereview.chromium.org/81213004/diff/90001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartHandleProxy.cpp (right):

https://codereview.chromium.org/81213004/diff/90001/Source/bindings/dart/Dart...
Source/bindings/dart/DartHandleProxy.cpp:235: 
On 2013/11/21 22:45:40, Jacob wrote:
> this is never getting called and would likely do the wrong thing if it was
> called. See the fixme above that the DartVM doesn't correctly handle invoking
> properties with private names.

What is it the VM does incorrectly? Nothing seems to go wrong if I remove the
skip condition above.

https://codereview.chromium.org/81213004/diff/90001/Source/bindings/dart/Dart...
Source/bindings/dart/DartHandleProxy.cpp:264: properties->Set(*count,
V8Converter::stringToV8(demangle(fieldName)));
On 2013/11/21 22:45:40, Jacob wrote:
> do private fields in libraries show up correctly with this change or are all
> their values "undefined"
> please explore a library in the private field to the devtools to verify.

I can see the value in the Scope Variables section.

Curiously, instance fields still have their mangling.

[siva, 2013-11-22 00:02:12]

lgtm

[Jacob, 2013-11-22 02:20:20]

lgtm

[rmacnak, 2013-11-25 18:40:17]

Committed patchset #4 manually as r1619 (presubmit successful).