Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 81213003: Fix default ARCHS value for iOS project. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Addressing comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/ios/app-bundle/TestApp/only-compile-in-32-bits.m » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/xcode_emulation.py
diff --git a/pylib/gyp/xcode_emulation.py b/pylib/gyp/xcode_emulation.py
index f2c1fd9858c0c93371f50d04ec527939550efe80..5e50f10df8e40fc4686f35e86d90f78b4d57618b 100644
--- a/pylib/gyp/xcode_emulation.py
+++ b/pylib/gyp/xcode_emulation.py
@@ -910,8 +910,23 @@ class XcodeSettings(object):
return items
def _DefaultArch(self):
- # The default value for ARCHS changed from ['i386'] to ['x86_64'] in
- # Xcode 5.
+ # For Mac projects, Xcode changed the default value used when ARCHS is not
+ # set from "i386" to "x86_64".
+ #
+ # For iOS projects, if ARCHS is unset, it defaults to "armv7 armv7s" when
+ # building for a device, and the simulator binaries are always build for
+ # "i386".
+ #
+ # For new projects, ARCHS is set to $(ARCHS_STANDARD_INCLUDING_64_BIT),
+ # which correspond to "armv7 armv7s arm64", and when building the simulator
+ # the architecture is either "i386" or "x86_64" depending on the simulated
+ # device (respectively 32-bit or 64-bit device).
+ #
+ # Since the value returned by this function is only used when ARCHS is not
+ # set, then on iOS we return "i386", as the default xcode project generator
+ # does not set ARCHS if it is not set in the .gyp file.
+ if self.isIOS:
+ return 'i386'
version, build = self._XcodeVersion()
if version >= '0500':
return 'x86_64'
« no previous file with comments | « no previous file | test/ios/app-bundle/TestApp/only-compile-in-32-bits.m » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698