Source/core/animation/LengthStyleInterpolation.cpp - Issue 811993002: Animation: Implement DoubleStyleInterpolation in StringKeyframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthStyleInterpolation.cpp

Issue 811993002: Animation: Implement DoubleStyleInterpolation in StringKeyframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created more layout tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/LengthStyleInterpolation.cpp

diff --git a/Source/core/animation/LengthStyleInterpolation.cpp b/Source/core/animation/LengthStyleInterpolation.cpp

index 27794a6609a7cffab5c244cb32d71943dbf7c182..f997e0410798b5904f5dfc2f7aa7738281a33956 100644

--- a/Source/core/animation/LengthStyleInterpolation.cpp

+++ b/Source/core/animation/LengthStyleInterpolation.cpp

@@ -26,7 +26,6 @@ bool LengthStyleInterpolation::canCreateFrom(const CSSValue& value)

PassOwnPtrWillBeRawPtr<InterpolableValue> LengthStyleInterpolation::lengthToInterpolableValue(const CSSValue& value)

{

- ASSERT(canCreateFrom(value));

alancutter (OOO until 2018) 2015/02/04 20:24:37 Leave this assert in.

jadeg 2015/02/05 23:37:02 Done.

OwnPtrWillBeRawPtr<InterpolableList> listOfValuesAndTypes = InterpolableList::create(2);

OwnPtrWillBeRawPtr<InterpolableList> listOfValues = InterpolableList::create(CSSPrimitiveValue::LengthUnitTypeCount);

OwnPtrWillBeRawPtr<InterpolableList> listOfTypes = InterpolableList::create(CSSPrimitiveValue::LengthUnitTypeCount);

« Source/core/animation/Keyframe.h ('K') | « Source/core/animation/Keyframe.h ('k') | Source/core/animation/StringKeyframe.h » ('j') | Source/core/animation/StringKeyframe.h » ('J')