Animation: Implement DoubleStyleInterpolation in StringKeyframe

Source/core/animation/DoubleStyleInterpolation.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/DoubleStyleInterpolation.h"
 
 #include "core/css/CSSCalculationValue.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/resolver/StyleBuilder.h"
 
 namespace blink {
 
 PassOwnPtrWillBeRawPtr<InterpolableValue> DoubleStyleInterpolation::doubleToInterpolableValue(const CSSValue& value)
 {
     ASSERT(canCreateFrom(value));
     const CSSPrimitiveValue& primitive = toCSSPrimitiveValue(value);
     return InterpolableNumber::create(primitive.getDoubleValue());
 }
 
 PassRefPtrWillBeRawPtr<CSSValue> DoubleStyleInterpolation::interpolableValueToDouble(InterpolableValue* value, ClampRange clamp)
 {
     ASSERT(value->isNumber());
     double doubleValue = toInterpolableNumber(value)->value();
-    if (clamp == ClampOpacity) {
-        doubleValue = clampTo<float>(doubleValue, 0, nextafterf(1, 0));
+    switch (clamp) {
+    case NoClamp:
+        // Do nothing
+        break;
+    case ClampOpacity:
+        doubleValue = clampTo<float>(doubleValue, 0, nextafter(0.9999, 0));

[alancutter (OOO until 2018), 2015/01/19 02:52:30]

Why did this change?

[jadeg, 2015/01/22 22:14:23]

Done.

+        break;
+    case ClampInteger:
+        doubleValue = floor(doubleValue);
+        break;
+    case ClampZoom:
+        doubleValue = clampTo<float>(doubleValue, 0.000000000000000000000000000000000000000000001);

[alancutter (OOO until 2018), 2015/01/19 02:52:30]

nextafterf(0, 1)?

[jadeg, 2015/01/22 22:14:23]

This clamps to zero, not the correct value

+        break;
+    case ClampOrphans:
+        doubleValue = clampTo<int>((doubleValue + 0.5), 1);
+        break;
+    case ClampOne:
+        doubleValue = clampTo<float>(doubleValue, 1);
+        break;
+    case ClampZero:
+        doubleValue = clampTo<float>(doubleValue, 0);
+        break;
     }
     return CSSPrimitiveValue::create(doubleValue, CSSPrimitiveValue::CSS_NUMBER);
 }
 
 bool DoubleStyleInterpolation::canCreateFrom(const CSSValue& value)
 {
     return value.isPrimitiveValue() && toCSSPrimitiveValue(value).isNumber();
 }
 
 void DoubleStyleInterpolation::apply(StyleResolverState& state) const
@@ skipping 73 matching lines @@
         || startRotationType != endRotationType)
         return nullptr;
 
     return adoptRefWillBeNoop(new DoubleStyleInterpolation(
         motionRotationToInterpolableValue(start),
         motionRotationToInterpolableValue(end),
         id, NoClamp, startRotationType == MotionRotationAuto));
 }
 
 }