LayoutTests/animations/interpolation/shape-image-threshold.html - Issue 811993002: Animation: Implement DoubleStyleInterpolation in StringKeyframe

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/animations/interpolation/shape-image-threshold.html

Issue 811993002: Animation: Implement DoubleStyleInterpolation in StringKeyframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created more layout tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/animations/interpolation/flex-interpolation.html ('K') | « LayoutTests/animations/interpolation/opacity-interpolation-expected.txt ('k') | LayoutTests/animations/interpolation/shape-image-threshold-expected.txt » ('j') | Source/core/animation/DoubleStyleInterpolation.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <meta charset="UTF-8">	2 <meta charset="UTF-8">

3 <body>	3 <body>

4 <script src="resources/interpolation-test.js"></script>	4 <script src="resources/interpolation-test.js"></script>

5 <script>	5 <script>

6 assertInterpolation({	6 assertInterpolation({

7 property: 'shape-image-threshold',	7 property: 'shape-image-threshold',

8 from: '0.5',	8 from: '0.5',

9 to: '1'	9 to: '1'

10 }, [	10 }, [

11 {at: -1.5, is: '0'},	11 {at: -1.5, is: '0'},

12 {at: -0.5, is: '0.25'},	12 {at: -0.5, is: '0.25'},

13 {at: 0, is: '0.5'},	13 {at: 0, is: '0.5'},

14 {at: 0.5, is: '0.75'},	14 {at: 0.5, is: '0.75'},

15 {at: 1, is: '1'},	15 {at: 1, is: '1'},

16 {at: 1.5, is: '1'}	16 {at: 1.5, is: '1'}

17 ]);	17 ]);

	18 assertInterpolation({

	19 property: 'shape-image-threshold',

	20 from: '2',

	21 to: '4'

	22 }, [

	23 {at: -1.5, is: '0'},

	24 {at: -0.75, is: '0.5'},

	25 {at: -0.5, is: '1'},

	26 {at: 0, is: '2'},

	27 {at: 0.5, is: '3'},

	28 {at: 1, is: '4'},

	29 {at: 1.5, is: '4'}
	alancutter (OOO until 2018) 2015/02/04 20:24:37 Why does this test pass? Your code now clamps betw Why does this test pass? Your code now clamps between [0, 1). jadeg 2015/02/05 23:37:01 Im really not sure, maybe you could come and help Show quoted text On 2015/02/04 20:24:37, alancutter wrote: > Why does this test pass? Your code now clamps between [0, 1). Im really not sure, maybe you could come and help investigate this? But ive moved it around, and it works either here or if I dont clamp it at all. It's being weird.
	30 ]);

18 </script>	31 </script>

19 </body>	32 </body>

OLD	NEW