Animation: Implement DoubleStyleInterpolation in StringKeyframe

Source/core/animation/DoubleStyleInterpolation.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/DoubleStyleInterpolation.h"
 
 #include "core/css/CSSCalculationValue.h"
 #include "core/css/resolver/StyleBuilder.h"
 
@@ skipping 14 matching lines @@
     if (primitive.isAngle())
         return InterpolableNumber::create(primitive.computeDegrees());
     ASSERT_NOT_REACHED();
     return nullptr;
 }
 
 PassRefPtrWillBeRawPtr<CSSValue> DoubleStyleInterpolation::interpolableValueToDouble(InterpolableValue* value, bool isNumber, InterpolationRange clamp)
 {
     ASSERT(value->isNumber());
     double doubleValue = toInterpolableNumber(value)->value();
-
     switch (clamp) {
-    case RangeOpacityFIXME:
-        doubleValue = clampTo<float>(doubleValue, 0, nextafterf(1, 0));
+    case RangeAll:
+        // Do nothing
+        break;
+    case RangeFloatFractions:
+        doubleValue = clampTo<float>(doubleValue, 0, nextafter(1, 0));
+        break;
+    case RangeFloor:
+        doubleValue = floor(doubleValue);
+        break;
+    case RangeDoubleFractions:
+        doubleValue = clampTo<double>(doubleValue, 0.000000000000000000000000000000000000000000001);

[Eric Willigers, 2015/01/28 22:24:44]

Consider using
  clampTo<double>(doubleValue, std::numeric_limits<double>::denorm_min());
like AnimatedStyleBuilder.cpp's case CSSPropertyZoom

See http://en.cppreference.com/w/cpp/types/numeric_limits/denorm_min

+        break;
+    case RangeCeiling:
+        doubleValue = clampTo<int>((doubleValue + 0.5), 1);
+        break;
+    case RangeGreaterThanOne:
+        doubleValue = clampTo<float>(doubleValue, 1);
         break;
     case RangeNonNegative:
         doubleValue = clampTo<float>(doubleValue, 0);
         break;
-    case RangeAll:
-        break;
-    default:
-        ASSERT_NOT_REACHED();
     }
-
     if (isNumber)
         return CSSPrimitiveValue::create(doubleValue, CSSPrimitiveValue::CSS_NUMBER);
     return CSSPrimitiveValue::create(doubleValue, CSSPrimitiveValue::CSS_DEG);
 }
 
 void DoubleStyleInterpolation::apply(StyleResolverState& state) const
 {
     if (m_id != CSSPropertyMotionRotation) {
         StyleBuilder::applyProperty(m_id, state, interpolableValueToDouble(m_cachedValue.get(), m_isNumber, m_clamp).get());
         return;
@@ skipping 69 matching lines @@
         || startRotationType != endRotationType)
         return nullptr;
 
     return adoptRefWillBeNoop(new DoubleStyleInterpolation(
         motionRotationToInterpolableValue(start),
         motionRotationToInterpolableValue(end),
         id, true, InterpolationRange::RangeAll, startRotationType == MotionRotationAuto));
 }
 
 }