Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: pkg/analysis_server/tool/spec/codegen_tools.dart

Issue 811973010: Fix checking of generated directory contents. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/codegen_tools.dart
diff --git a/pkg/analysis_server/tool/spec/codegen_tools.dart b/pkg/analysis_server/tool/spec/codegen_tools.dart
index 922b4823de6eb4a804bf55dff70313027f8a3209..898f4b777c2d34ae46b43e583015308181872dcf 100644
--- a/pkg/analysis_server/tool/spec/codegen_tools.dart
+++ b/pkg/analysis_server/tool/spec/codegen_tools.dart
@@ -211,14 +211,15 @@ class GeneratedDirectory extends GeneratedContent {
bool check() {
Map<String, FileContentsComputer> map = directoryContentsComputer();
try {
- map.forEach((String file, FileContentsComputer fileContentsComputer) {
+ for (String file in map.keys) {
+ FileContentsComputer fileContentsComputer = map[file];
String expectedContents = fileContentsComputer();
File outputFile =
new File(joinAll(posix.split(posix.join(outputDirPath, file))));
if (expectedContents != outputFile.readAsStringSync()) {
return false;
}
- });
+ }
int nonHiddenFileCount = 0;
outputFile.listSync(
recursive: false,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698