Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 811953005: cc: Remove tile and scale specific code from raster source (Closed)

Created:
5 years, 11 months ago by hendrikw
Modified:
5 years, 11 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove tile and scale specific code from raster source Fix a TODO I added a while back. Instead of calling SetMinContentsScale and SetTileGridSize directly, pass these as parameters to constructor of the PicturePile. Committed: https://crrev.com/6d1f2981f3204852a9189d0b6e7ad0b18659d68d Cr-Commit-Position: refs/heads/master@{#309867} Committed: https://crrev.com/751c4ac09673e018b7e9cb92b95fe4304d66c6f7 Cr-Commit-Position: refs/heads/master@{#313183}

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit exterminated #

Patch Set 3 : fix tests #

Patch Set 4 : floatify #

Patch Set 5 : merge #

Patch Set 6 : updated some newer tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -36 lines) Patch
M cc/layers/picture_layer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/resources/display_list_recording_source.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/display_list_recording_source.cc View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
M cc/resources/picture_pile.h View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M cc/resources/picture_pile.cc View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M cc/resources/picture_pile_unittest.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M cc/resources/recording_source.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/fake_picture_pile.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 1 2 3 4 4 chunks +11 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 5 5 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
hendrikw
PTAL
5 years, 11 months ago (2015-01-02 19:09:26 UTC) #2
vmpstr
lgtm https://codereview.chromium.org/811953005/diff/1/cc/resources/picture_pile.h File cc/resources/picture_pile.h (right): https://codereview.chromium.org/811953005/diff/1/cc/resources/picture_pile.h#newcode23 cc/resources/picture_pile.h:23: PicturePile(double min_content_scale, const gfx::Size& tile_grid_size); nit: min_contents_scale
5 years, 11 months ago (2015-01-02 19:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811953005/20001
5 years, 11 months ago (2015-01-02 19:57:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/19138)
5 years, 11 months ago (2015-01-02 21:03:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811953005/60001
5 years, 11 months ago (2015-01-03 00:16:57 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-03 01:16:01 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/6d1f2981f3204852a9189d0b6e7ad0b18659d68d Cr-Commit-Position: refs/heads/master@{#309867}
5 years, 11 months ago (2015-01-03 01:16:54 UTC) #11
jdduke (slow)
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/832963002/ by jdduke@chromium.org. ...
5 years, 11 months ago (2015-01-03 02:05:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811953005/100001
5 years, 11 months ago (2015-01-27 00:06:32 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-27 01:00:03 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 01:00:59 UTC) #16
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/751c4ac09673e018b7e9cb92b95fe4304d66c6f7
Cr-Commit-Position: refs/heads/master@{#313183}

Powered by Google App Engine
This is Rietveld 408576698