Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 81193002: Pythonification and refactoring of push-to-trunk. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Pythonification and refactoring of push-to-trunk. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17995

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Refactor step generation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -136 lines) Patch
M tools/push-to-trunk/auto_roll.py View 1 2 4 chunks +4 lines, -8 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 2 7 chunks +36 lines, -35 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 2 25 chunks +32 lines, -56 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 2 7 chunks +29 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 1 month ago (2013-11-21 16:11:56 UTC) #1
Michael Achenbach
Patch 3 adds a factory method for the step generation and removes some boiler plate ...
7 years, 1 month ago (2013-11-22 09:03:37 UTC) #2
Jakob Kummerow
lgtm
7 years, 1 month ago (2013-11-22 09:42:58 UTC) #3
Michael Achenbach
7 years, 1 month ago (2013-11-22 09:48:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r17995.

Powered by Google App Engine
This is Rietveld 408576698