Changes to support CDM_7

ppapi/cpp/private/content_decryptor_private.cc

Index: ppapi/cpp/private/content_decryptor_private.cc
diff --git a/ppapi/cpp/private/content_decryptor_private.cc b/ppapi/cpp/private/content_decryptor_private.cc
index 65f822cc2b0113bb46b2521c5a3fdb99fbc6fd3c..f17132209606b70aed258643d57446de67c4e0be 100644
--- a/ppapi/cpp/private/content_decryptor_private.cc
+++ b/ppapi/cpp/private/content_decryptor_private.cc
@@ -56,11 +56,11 @@ void SetServerCertificate(PP_Instance instance,
       ->SetServerCertificate(promise_id, server_certificate);
 }
 
-void CreateSession(PP_Instance instance,
-                   uint32_t promise_id,
-                   PP_Var init_data_type_arg,
-                   PP_Var init_data_arg,
-                   PP_SessionType session_type) {
+void CreateSessionAndGenerateRequest(PP_Instance instance,
+                                     uint32_t promise_id,
+                                     PP_SessionType session_type,
+                                     PP_Var init_data_type_arg,
+                                     PP_Var init_data_arg) {
   void* object =
       Instance::GetPerInstanceObject(instance, kPPPContentDecryptorInterface);
   if (!object)
@@ -76,14 +76,14 @@ void CreateSession(PP_Instance instance,
   pp::VarArrayBuffer init_data_array_buffer(init_data_var);
 
   static_cast<ContentDecryptor_Private*>(object)
-      ->CreateSession(promise_id,
-                      init_data_type_var.AsString(),
-                      init_data_array_buffer,
-                      session_type);
+      ->CreateSessionAndGenerateRequest(promise_id, session_type,
+                                        init_data_type_var.AsString(),
+                                        init_data_array_buffer);
 }
 
 void LoadSession(PP_Instance instance,
                  uint32_t promise_id,
+                 PP_SessionType session_type,
                  PP_Var web_session_id_arg) {
   void* object =
       Instance::GetPerInstanceObject(instance, kPPPContentDecryptorInterface);
@@ -95,7 +95,7 @@ void LoadSession(PP_Instance instance,
     return;
 
   static_cast<ContentDecryptor_Private*>(object)
-      ->LoadSession(promise_id, web_session_id_var.AsString());
+      ->LoadSession(promise_id, session_type, web_session_id_var.AsString());
 }
 
 void UpdateSession(PP_Instance instance,
@@ -152,22 +152,6 @@ void RemoveSession(PP_Instance instance,
       ->RemoveSession(promise_id, web_session_id_var.AsString());
 }
 
-void GetUsableKeyIds(PP_Instance instance,
-                     uint32_t promise_id,
-                     PP_Var web_session_id_arg) {
-  void* object =
-      Instance::GetPerInstanceObject(instance, kPPPContentDecryptorInterface);
-  if (!object)
-    return;
-
-  pp::Var web_session_id_var(web_session_id_arg);
-  if (!web_session_id_var.is_string())
-    return;
-
-  static_cast<ContentDecryptor_Private*>(object)
-      ->GetUsableKeyIds(promise_id, web_session_id_var.AsString());
-}
-
 void Decrypt(PP_Instance instance,
              PP_Resource encrypted_resource,
              const PP_EncryptedBlockInfo* encrypted_block_info) {
@@ -258,12 +242,11 @@ void DecryptAndDecode(PP_Instance instance,
 const PPP_ContentDecryptor_Private ppp_content_decryptor = {
     &Initialize,
     &SetServerCertificate,
-    &CreateSession,
+    &CreateSessionAndGenerateRequest,
     &LoadSession,
     &UpdateSession,
     &CloseSession,
     &RemoveSession,
-    &GetUsableKeyIds,
     &Decrypt,
     &InitializeAudioDecoder,
     &InitializeVideoDecoder,
@@ -309,23 +292,6 @@ void ContentDecryptor_Private::PromiseResolvedWithSession(
   }
 }
 
-void ContentDecryptor_Private::PromiseResolvedWithKeyIds(
-    uint32_t promise_id,
-    const std::vector<std::vector<uint8_t> >& key_ids) {
-  if (has_interface<PPB_ContentDecryptor_Private>()) {
-    pp::VarArray key_ids_array = pp::VarArray();
-    key_ids_array.SetLength(key_ids.size());
-    for (size_t i = 0; i < key_ids.size(); ++i) {
-      const std::vector<uint8_t>& entry = key_ids[i];
-      pp::VarArrayBuffer array_buffer(entry.size());
-      memcpy(array_buffer.Map(), &entry[0], entry.size());
-      key_ids_array.Set(i, array_buffer);
-    }
-    get_interface<PPB_ContentDecryptor_Private>()->PromiseResolvedWithKeyIds(
-        associated_instance_.pp_instance(), promise_id, key_ids_array.pp_var());
-  }
-}
-
 void ContentDecryptor_Private::PromiseRejected(
     uint32_t promise_id,
     PP_CdmExceptionCode exception_code,
@@ -342,30 +308,34 @@ void ContentDecryptor_Private::PromiseRejected(
   }
 }
 
-void ContentDecryptor_Private::SessionMessage(
-    const std::string& web_session_id,
-    pp::VarArrayBuffer message,
-    const std::string& destination_url) {
+void ContentDecryptor_Private::SessionMessage(const std::string& web_session_id,
+                                              PP_MessageType message_type,
+                                              pp::VarArrayBuffer message) {
   if (has_interface<PPB_ContentDecryptor_Private>()) {
     pp::Var web_session_id_var(web_session_id);
-    pp::Var destination_url_var(destination_url);
     get_interface<PPB_ContentDecryptor_Private>()->SessionMessage(
-        associated_instance_.pp_instance(),
-        web_session_id_var.pp_var(),
-        message.pp_var(),
-        destination_url_var.pp_var());
+        associated_instance_.pp_instance(), web_session_id_var.pp_var(),
+        message_type, message.pp_var());
   }
 }
 
 void ContentDecryptor_Private::SessionKeysChange(
     const std::string& web_session_id,
-    bool has_additional_usable_key) {
+    bool has_additional_usable_key,
+    const std::vector<PP_KeyInformation>& key_information) {
   if (has_interface<PPB_ContentDecryptor_Private>()) {
     pp::Var web_session_id_var(web_session_id);
+    pp::VarArray key_information_array = pp::VarArray();
+    key_information_array.SetLength(key_information.size());
+    for (size_t i = 0; i < key_information.size(); ++i) {
+      auto entry = key_information[i];

[dcheng, 2014/12/18 22:35:03]

Isn't this a copy? Qualify this with const auto&.

[jrummell, 2014/12/18 23:47:59]

Done.

+      pp::VarArrayBuffer array_buffer(sizeof(PP_KeyInformation));

[dcheng, 2014/12/18 22:35:03]

You could use sizeof(entry) here to make this "future" proof, in case the
std::vector<> ever holds something that's not a PP_KeyInformation. I don't know
if that's a common pattern in ppapi code though.

[jrummell, 2014/12/18 23:47:59]

Done.

+      memcpy(array_buffer.Map(), &entry, sizeof(PP_KeyInformation));
+      key_information_array.Set(i, array_buffer);
+    }
     get_interface<PPB_ContentDecryptor_Private>()->SessionKeysChange(
-        associated_instance_.pp_instance(),
-        web_session_id_var.pp_var(),
-        PP_FromBool(has_additional_usable_key));
+        associated_instance_.pp_instance(), web_session_id_var.pp_var(),
+        PP_FromBool(has_additional_usable_key), key_information_array.pp_var());
   }
 }
 
@@ -381,14 +351,6 @@ void ContentDecryptor_Private::SessionExpirationChange(
   }
 }
 
-void ContentDecryptor_Private::SessionReady(const std::string& web_session_id) {
-  if (has_interface<PPB_ContentDecryptor_Private>()) {
-    pp::Var web_session_id_var(web_session_id);
-    get_interface<PPB_ContentDecryptor_Private>()->SessionReady(
-        associated_instance_.pp_instance(), web_session_id_var.pp_var());
-  }
-}
-
 void ContentDecryptor_Private::SessionClosed(
     const std::string& web_session_id) {
   if (has_interface<PPB_ContentDecryptor_Private>()) {