Issue 811913004: Update ColorFilterImageFilter & BlurImageFilter debugger strings

Issue 811913004: Update ColorFilterImageFilter & BlurImageFilter debugger strings (Closed)

Created:
6 years ago by robertphillips

Modified:
6 years ago

Reviewers:
reed1

CC:
reviews_skia.org, senorblanco

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Update ColorFilterImageFilter & BlurImageFilter debugger strings This CL allows us to see the image filter DAG in the debugger. Committed: https://skia.googlesource.com/skia/+/33cca886b757ed575136a628b30e845096ef94a3

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	src/effects/SkBlurImageFilter.cpp	View		1 chunk	+7 lines, -2 lines	0 comments	Download
	M	src/effects/SkColorFilterImageFilter.cpp	View		1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 11 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811913004/1

6 years ago (2014-12-22 14:40:34 UTC) #4

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

6 years ago (2014-12-22 14:40:35 UTC) #5

reed1

lgtm in some places, the code looks at fColorFilter, and in some places it looks ...

6 years ago (2014-12-22 14:42:50 UTC) #7

robertphillips

The ColorFilterImageFilter wraps an SkColorFilter and applies it as an ImageFilter in the DAG. fColorFilter ...

6 years ago (2014-12-22 14:50:02 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811913004/1

6 years ago (2014-12-22 14:51:54 UTC) #10

commit-bot: I haz the power

6 years ago (2014-12-22 14:52:07 UTC) #11

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/33cca886b757ed575136a628b30e845096ef94a3