Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: src/core/SkXfermode.cpp

Issue 811903004: Do more cleanup from xp changes (Closed) Base URL: https://skia.googlesource.com/skia.git@removeReadDst
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkXfermode.cpp
diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp
index 37dbd0d1e24a264864873e2315b9e3e6b69dc19a..1b28d1e147b911e746afaa02841c44f4fb99ffef 100644
--- a/src/core/SkXfermode.cpp
+++ b/src/core/SkXfermode.cpp
@@ -687,30 +687,30 @@ bool SkXfermode::asXPFactory(GrXPFactory**) const {
#if SK_SUPPORT_GPU
#include "effects/GrPorterDuffXferProcessor.h"
-bool SkXfermode::AsFragmentProcessorOrXPFactory(SkXfermode* xfermode,
- GrFragmentProcessor** fp,
- GrXPFactory** xpf) {
+bool SkXfermode::AsXPFactory(SkXfermode* xfermode, GrXPFactory** xpf) {
Coeff src, dst;
Mode mode;
if (NULL == xfermode) {
- *xpf = GrPorterDuffXPFactory::Create(kSrcOver_Mode);
+ if (xpf) {
+ *xpf = GrPorterDuffXPFactory::Create(kSrcOver_Mode);
+ }
return true;
} else if (xfermode->asMode(&mode) && mode <= kLastCoeffMode) {
- *xpf = GrPorterDuffXPFactory::Create(mode);
+ if (xpf) {
+ *xpf = GrPorterDuffXPFactory::Create(mode);
+ }
return true;
} else if (xfermode->asCoeff(&src, &dst)) {
- *xpf = GrPorterDuffXPFactory::Create(src, dst);
- return true;
- } else if (xfermode->asXPFactory(xpf)) {
+ if (xpf) {
+ *xpf = GrPorterDuffXPFactory::Create(src, dst);
+ }
return true;
} else {
- return xfermode->asFragmentProcessor(fp, NULL);
+ return xfermode->asXPFactory(xpf);
}
}
#else
-bool SkXfermode::AsFragmentProcessorOrXPFactory(SkXfermode* xfermode,
- GrFragmentProcessor** fp,
- GrXPFactory** xpf) {
+bool SkXfermode::AsXPFactory(SkXfermode* xfermode, GrXPFactory** xpf) {
return false;
}
#endif
« include/core/SkXfermode.h ('K') | « include/core/SkXfermode.h ('k') | src/gpu/SkGr.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698