Do more cleanup from xp changes

Do more cleanup from xp changes

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/58136167fc596fb945b58b34f500cf370c0dec7c

[egdaniel, 2015-01-20 14:51:53]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com

[egdaniel, 2015-01-20 14:51:54]

Just some simple cleanup stuff now that XP's are fully running.

[bsalomon, 2015-01-20 14:59:34]

lgtm

https://codereview.chromium.org/811903004/diff/1/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.chromium.org/811903004/diff/1/include/core/SkXfermode.h#ne...
include/core/SkXfermode.h:211: This helper calls the asMode(), asCoeff() and
asXPFactory() virtuals. If the xfermode is
Do we still need asMode() and asCoeff() or can those be supplanted by asFP and
asXPF?

[egdaniel, 2015-01-20 16:03:12]

https://codereview.chromium.org/811903004/diff/1/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.chromium.org/811903004/diff/1/include/core/SkXfermode.h#ne...
include/core/SkXfermode.h:211: This helper calls the asMode(), asCoeff() and
asXPFactory() virtuals. If the xfermode is
On 2015/01/20 14:59:34, bsalomon wrote:
> Do we still need asMode() and asCoeff() or can those be supplanted by asFP and
> asXPF?

Removed the need to check these in this function.

[bsalomon, 2015-01-20 16:16:37]

https://codereview.chromium.org/811903004/diff/20001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/811903004/diff/20001/src/core/SkXfermode.cpp#...
src/core/SkXfermode.cpp:925: if (this->asCoeff(NULL, NULL)) {
could asCoeff be a non-virtual that took a mode?

[egdaniel, 2015-01-20 18:07:45]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-01-20 18:10:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/811903004/40001

[commit-bot: I haz the power, 2015-01-20 18:19:36]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/58136167fc596fb945b58b34f500cf370c0dec7c