Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811873003: Move Sky's DataPipeDrainer to mojo/common (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
jimbe
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move Sky's DataPipeDrainer to mojo/common I want to use DataPipeDrainer in some non-sky code it seems generally useful (and compiled w/o modification). R=jimbe@chromium.org, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6dda10c77f8b9028e0ebc2f741c52036c50019ba

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -113 lines) Patch
M mojo/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/common/data_pipe_drainer.h View 2 chunks +7 lines, -5 lines 0 comments Download
A + mojo/common/data_pipe_drainer.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.h View 1 chunk +1 line, -1 line 1 comment Download
M sky/engine/core/html/parser/BackgroundHTMLParser.h View 4 chunks +4 lines, -3 lines 0 comments Download
M sky/engine/core/html/parser/BackgroundHTMLParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/platform/fetcher/DataPipeDrainer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/engine/platform/fetcher/DataPipeDrainer.cpp View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
6 years ago (2014-12-17 01:17:38 UTC) #1
eseidel
I'm told jim may be a better reviewer.
6 years ago (2014-12-17 01:19:29 UTC) #3
jimbe
lgtm LGTM, with one nit. https://codereview.chromium.org/811873003/diff/1/sky/engine/core/html/imports/HTMLImportLoader.h File sky/engine/core/html/imports/HTMLImportLoader.h (right): https://codereview.chromium.org/811873003/diff/1/sky/engine/core/html/imports/HTMLImportLoader.h#newcode34 sky/engine/core/html/imports/HTMLImportLoader.h:34: #include "mojo/common/data_pipe_drainer.h" Can this ...
6 years ago (2014-12-17 18:08:18 UTC) #4
eseidel
6 years ago (2014-12-17 20:16:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6dda10c77f8b9028e0ebc2f741c52036c50019ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698