Issue 811863006: Revert of enable conics gm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 811863006: Revert of enable conics gm (Closed)

Created:
5 years, 11 months ago by reed2

Modified:
5 years, 11 months ago

Reviewers:
egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of enable conics gm (patchset #3 id:40001 of https://codereview.chromium.org/835593002/) Reason for revert: did I break the build? Original issue's description: > enable conics gm > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/03119ba4f815bc2c2774a9349ca8278ab1695072 TBR=egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ede901c7a2e21a44552b8c1436d9521ce33f4de5

Patch Set 1 #

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -40 lines)			Patch
M	gm/conicpaths.cpp	View	3 chunks	+40 lines, -21 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFUtils.cpp	View	3 chunks	+9 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811863006/1

5 years, 11 months ago (2015-01-05 04:52:08 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ede901c7a2e21a44552b8c1436d9521ce33f4de5

5 years, 11 months ago (2015-01-05 04:52:18 UTC) #3

reed1

5 years, 11 months ago (2015-01-05 18:00:33 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/836773002/ by reed@google.com.

The reason for reverting is: maybe this wasn't the cause of the chromeos crash?.

Expand Messages | Collapse Messages