Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 811863003: replace COMPILE_ASSERT with static_assert in core/html/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
keishi, philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in core/html/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/parser/CompactHTMLToken.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/BufferedLineReaderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mostyn Bramley-Moore
@keishi, Philip: PTAL.
6 years ago (2014-12-16 22:40:37 UTC) #2
philipj_slow
lgtm
6 years ago (2014-12-16 23:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811863003/1
6 years ago (2014-12-16 23:13:34 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 01:25:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187317

Powered by Google App Engine
This is Rietveld 408576698