Source/core/rendering/RenderTableSection.cpp - Issue 811843003: replace COMPILE_ASSERT with static_assert in core/rendering/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableSection.cpp

Issue 811843003: replace COMPILE_ASSERT with static_assert in core/rendering/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderTableSection.cpp

diff --git a/Source/core/rendering/RenderTableSection.cpp b/Source/core/rendering/RenderTableSection.cpp

index a41c97a5de7950ca19ec976c8127dd7d73bced19..b779a5f80271bb4b27681adf620986b14ac4f8b9 100644

--- a/Source/core/rendering/RenderTableSection.cpp

+++ b/Source/core/rendering/RenderTableSection.cpp

@@ -351,7 +351,7 @@ void RenderTableSection::distributeExtraRowSpanHeightToPercentRows(RenderTableCe

// problem in this function.

static void updatePositionIncreasedWithRowHeight(long long extraHeight, long long rowHeight, long long totalHeight, int& accumulatedPositionIncrease, int& remainder)

{

- COMPILE_ASSERT(sizeof(long long int) > sizeof(int), int_should_be_less_than_longlong);

+ static_assert(sizeof(long long int) > sizeof(int), "int should be smaller than long long");

accumulatedPositionIncrease += (extraHeight * rowHeight) / totalHeight;

remainder += (extraHeight * rowHeight) % totalHeight;

« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderText.cpp » ('j') | no next file with comments »