Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811843003: replace COMPILE_ASSERT with static_assert in core/rendering/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in core/rendering/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M Source/core/rendering/FloatingObjects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/PaintPhase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/PointerEventsHitRules.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/TextAutosizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/break_lines.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/FillLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleBoxData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Mostyn Bramley-Moore
@timloh: PTAL.
6 years ago (2014-12-16 20:09:10 UTC) #2
Timothy Loh
On 2014/12/16 20:09:10, Mostyn Bramley-Moore wrote: > @timloh: PTAL. lgtm
6 years ago (2014-12-16 22:49:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811843003/1
6 years ago (2014-12-16 23:03:19 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 00:24:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187306

Powered by Google App Engine
This is Rietveld 408576698