Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: base/prefs/pref_service.h

Issue 81183005: Remove JsonPrefStore pruning of empty values on write. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove else Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/pref_registry.cc ('k') | base/prefs/pref_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_service.h
diff --git a/base/prefs/pref_service.h b/base/prefs/pref_service.h
index 9f4dc7c1b68b7bf252c5d219a22feba41fe6b2aa..176594a64d381ae72b3a881fe88dbad3022b1629 100644
--- a/base/prefs/pref_service.h
+++ b/base/prefs/pref_service.h
@@ -221,13 +221,6 @@ class BASE_PREFS_EXPORT PrefService : public base::NonThreadSafe {
// registered preference. In that case, will never return NULL.
const base::Value* GetDefaultPrefValue(const char* path) const;
- // Deprecated. Do not add calls to this method.
- // Marks that the user store should not prune out empty values for |key| when
- // writting to disk.
- // TODO(gab): Enforce this at a lower level for all values and remove this
- // method.
- void MarkUserStoreNeedsEmptyValue(const std::string& key) const;
-
// Returns true if a value has been set for the specified path.
// NOTE: this is NOT the same as FindPreference. In particular
// FindPreference returns whether RegisterXXX has been invoked, where as
@@ -268,17 +261,6 @@ class BASE_PREFS_EXPORT PrefService : public base::NonThreadSafe {
PrefRegistry* DeprecatedGetPrefRegistry();
protected:
- // Adds the registered preferences from the PrefRegistry instance
- // passed to us at construction time.
- void AddInitialPreferences();
-
- // Updates local caches for a preference registered at |path|. The
- // |default_value| must not be NULL as it determines the preference
- // value's type. AddRegisteredPreference must not be called twice
- // for the same path.
- void AddRegisteredPreference(const char* path,
- base::Value* default_value);
-
// The PrefNotifier handles registering and notifying preference observers.
// It is created and owned by this PrefService. Subclasses may access it for
// unit testing.
« no previous file with comments | « base/prefs/pref_registry.cc ('k') | base/prefs/pref_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698