Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: chrome/browser/prefs/pref_metrics_service.cc

Issue 81183005: Remove JsonPrefStore pruning of empty values on write. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/values.cc ('K') | « chrome/browser/prefs/chrome_pref_service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_metrics_service.cc
diff --git a/chrome/browser/prefs/pref_metrics_service.cc b/chrome/browser/prefs/pref_metrics_service.cc
index 0bc8c1779dde865207af00007088761fd33eecf0..3fbdaf4e6817f2e686c3ec395323988fa92b6fe0 100644
--- a/chrome/browser/prefs/pref_metrics_service.cc
+++ b/chrome/browser/prefs/pref_metrics_service.cc
@@ -299,11 +299,6 @@ void PrefMetricsService::CheckTrackedPreferences() {
if (!prefs_->FindPreference(tracked_pref_paths_[i]))
continue;
- // Make sure tracked prefs are saved to disk even if empty.
- // TODO(gab): Guarantee this for all prefs at a lower level and remove this
- // hack.
- prefs_->MarkUserStoreNeedsEmptyValue(tracked_pref_paths_[i]);
-
const base::Value* value = prefs_->GetUserPrefValue(tracked_pref_paths_[i]);
std::string last_hash;
// First try to get the stored expected hash...
« base/values.cc ('K') | « chrome/browser/prefs/chrome_pref_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698