Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: base/prefs/overlay_user_pref_store.h

Issue 81183005: Remove JsonPrefStore pruning of empty values on write. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove else Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/prefs/json_pref_store_unittest.cc ('k') | base/prefs/overlay_user_pref_store.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_PREFS_OVERLAY_USER_PREF_STORE_H_ 5 #ifndef BASE_PREFS_OVERLAY_USER_PREF_STORE_H_
6 #define BASE_PREFS_OVERLAY_USER_PREF_STORE_H_ 6 #define BASE_PREFS_OVERLAY_USER_PREF_STORE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 26 matching lines...) Expand all
37 virtual bool GetValue(const std::string& key, 37 virtual bool GetValue(const std::string& key,
38 const base::Value** result) const OVERRIDE; 38 const base::Value** result) const OVERRIDE;
39 39
40 // Methods of PersistentPrefStore. 40 // Methods of PersistentPrefStore.
41 virtual bool GetMutableValue(const std::string& key, 41 virtual bool GetMutableValue(const std::string& key,
42 base::Value** result) OVERRIDE; 42 base::Value** result) OVERRIDE;
43 virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE; 43 virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE;
44 virtual void SetValueSilently(const std::string& key, 44 virtual void SetValueSilently(const std::string& key,
45 base::Value* value) OVERRIDE; 45 base::Value* value) OVERRIDE;
46 virtual void RemoveValue(const std::string& key) OVERRIDE; 46 virtual void RemoveValue(const std::string& key) OVERRIDE;
47 virtual void MarkNeedsEmptyValue(const std::string& key) OVERRIDE;
48 virtual bool ReadOnly() const OVERRIDE; 47 virtual bool ReadOnly() const OVERRIDE;
49 virtual PrefReadError GetReadError() const OVERRIDE; 48 virtual PrefReadError GetReadError() const OVERRIDE;
50 virtual PrefReadError ReadPrefs() OVERRIDE; 49 virtual PrefReadError ReadPrefs() OVERRIDE;
51 virtual void ReadPrefsAsync(ReadErrorDelegate* delegate) OVERRIDE; 50 virtual void ReadPrefsAsync(ReadErrorDelegate* delegate) OVERRIDE;
52 virtual void CommitPendingWrite() OVERRIDE; 51 virtual void CommitPendingWrite() OVERRIDE;
53 virtual void ReportValueChanged(const std::string& key) OVERRIDE; 52 virtual void ReportValueChanged(const std::string& key) OVERRIDE;
54 53
55 // Methods of PrefStore::Observer. 54 // Methods of PrefStore::Observer.
56 virtual void OnPrefValueChanged(const std::string& key) OVERRIDE; 55 virtual void OnPrefValueChanged(const std::string& key) OVERRIDE;
57 virtual void OnInitializationCompleted(bool succeeded) OVERRIDE; 56 virtual void OnInitializationCompleted(bool succeeded) OVERRIDE;
(...skipping 18 matching lines...) Expand all
76 ObserverList<PrefStore::Observer, true> observers_; 75 ObserverList<PrefStore::Observer, true> observers_;
77 PrefValueMap overlay_; 76 PrefValueMap overlay_;
78 scoped_refptr<PersistentPrefStore> underlay_; 77 scoped_refptr<PersistentPrefStore> underlay_;
79 NamesMap overlay_to_underlay_names_map_; 78 NamesMap overlay_to_underlay_names_map_;
80 NamesMap underlay_to_overlay_names_map_; 79 NamesMap underlay_to_overlay_names_map_;
81 80
82 DISALLOW_COPY_AND_ASSIGN(OverlayUserPrefStore); 81 DISALLOW_COPY_AND_ASSIGN(OverlayUserPrefStore);
83 }; 82 };
84 83
85 #endif // BASE_PREFS_OVERLAY_USER_PREF_STORE_H_ 84 #endif // BASE_PREFS_OVERLAY_USER_PREF_STORE_H_
OLDNEW
« no previous file with comments | « base/prefs/json_pref_store_unittest.cc ('k') | base/prefs/overlay_user_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698