Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: snapshot/mac/mach_o_image_annotations_reader_test.cc

Issue 811823003: Cross platform low level file IO wrappers (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | snapshot/mac/process_reader_test.cc » ('j') | util/file/file_io.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/mac/mach_o_image_annotations_reader_test.cc
diff --git a/snapshot/mac/mach_o_image_annotations_reader_test.cc b/snapshot/mac/mach_o_image_annotations_reader_test.cc
index c2ee368552386e7266ee95b5cad3649c6eef6675..01ecc7a06b0db412b9c7158d72496fbef449f75b 100644
--- a/snapshot/mac/mach_o_image_annotations_reader_test.cc
+++ b/snapshot/mac/mach_o_image_annotations_reader_test.cc
@@ -30,7 +30,7 @@
#include "client/simple_string_dictionary.h"
#include "gtest/gtest.h"
#include "snapshot/mac/process_reader.h"
-#include "util/file/fd_io.h"
+#include "util/file/file_io.h"
#include "util/mac/mac_util.h"
#include "util/mach/exc_server_variants.h"
#include "util/mach/exception_ports.h"
@@ -193,7 +193,7 @@ class TestMachOImageAnnotationsReader final
// Wait for the child process to indicate that it’s done setting up its
// annotations via the CrashpadInfo interface.
char c;
- CheckedReadFD(ReadPipeFD(), &c, sizeof(c));
+ CheckedReadFile(ReadPipeFD(), &c, sizeof(c));
// Verify the “simple map” annotations set via the CrashpadInfo interface.
const std::vector<ProcessReader::Module>& modules =
@@ -216,7 +216,7 @@ class TestMachOImageAnnotationsReader final
EXPECT_EQ("", all_annotations_simple_map["#TEST# empty_value"]);
// Tell the child process that it’s permitted to crash.
- CheckedWriteFD(WritePipeFD(), &c, sizeof(c));
+ CheckedWriteFile(WritePipeFD(), &c, sizeof(c));
if (test_type_ != kDontCrash) {
// Handle the child’s crash. Further validation will be done in
@@ -268,10 +268,10 @@ class TestMachOImageAnnotationsReader final
// Tell the parent that the environment has been set up.
char c = '\0';
- CheckedWriteFD(WritePipeFD(), &c, sizeof(c));
+ CheckedWriteFile(WritePipeFD(), &c, sizeof(c));
// Wait for the parent to indicate that it’s safe to crash.
- CheckedReadFD(ReadPipeFD(), &c, sizeof(c));
+ CheckedReadFile(ReadPipeFD(), &c, sizeof(c));
// Direct an exception message to the exception server running in the
// parent.
« no previous file with comments | « no previous file | snapshot/mac/process_reader_test.cc » ('j') | util/file/file_io.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698