Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811793002: ServiceWorker: Expose registration within ServiceWorkerGlobalScope [1/3] (Closed)

Created:
6 years ago by nhiroki
Modified:
5 years, 11 months ago
Reviewers:
kinuko, Mike West
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Expose registration within ServiceWorkerGlobalScope [1/3] This CL introduces ".registration" attribute in ServiceWorkerGlobalScope. Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-global-scope [1] Blink: THIS PATCH [2] Chromium: https://codereview.chromium.org/849163002/ [3] Blink: https://codereview.chromium.org/822593003/ BUG=437677 TEST=run-webkit-tests --debug http/tests/serviceworker/interfaces.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188616

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 4 chunks +6 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 4 chunks +16 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nhiroki
Ptal, thanks!
5 years, 11 months ago (2015-01-16 06:51:08 UTC) #5
kinuko
lgtm
5 years, 11 months ago (2015-01-19 04:07:22 UTC) #6
nhiroki
+mkwst@, can you review Source/web and public/web? Thanks.
5 years, 11 months ago (2015-01-19 04:15:22 UTC) #8
Mike West
LGTM.
5 years, 11 months ago (2015-01-19 08:55:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811793002/60001
5 years, 11 months ago (2015-01-19 11:00:31 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 11:45:34 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188616

Powered by Google App Engine
This is Rietveld 408576698