Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 811783004: [WebCrypto] Test update of RSA Key Generation when publicExponent is not in supported range (Closed)

Created:
6 years ago by Habib Virji
Modified:
6 years ago
Reviewers:
eroman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WebCrypto] Test update of RSA Key Generation when publicExponent is not in supported range Test updated for the generateKey instead of DataError, OperationError is thrown when publicExponent for RSA key generation is not in supported range. BUG=441876 R=eroman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187524

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved to common place for crypto tests #

Total comments: 4

Patch Set 3 : Updated comment in TestExpectations #

Patch Set 4 : #

Patch Set 5 : "Updated to latest master" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/crypto/rsa-ssa-generateKey-parseAlgorithm-failures-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
eroman
https://codereview.chromium.org/811783004/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/811783004/diff/1/LayoutTests/TestExpectations#newcode1232 LayoutTests/TestExpectations:1232: crbug.com/441876 crypto/rsa-ssa-generateKey-parseAlgorithm-failures.html [ Failure Pass ] Please move this ...
6 years ago (2014-12-18 20:45:00 UTC) #1
Habib Virji
Updated. https://codereview.chromium.org/811783004/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/811783004/diff/1/LayoutTests/TestExpectations#newcode1232 LayoutTests/TestExpectations:1232: crbug.com/441876 crypto/rsa-ssa-generateKey-parseAlgorithm-failures.html [ Failure Pass ] On 2014/12/18 ...
6 years ago (2014-12-19 00:12:18 UTC) #2
eroman
lgtm https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations#newcode617 LayoutTests/TestExpectations:617: # Below crypto are temporary till chromium side ...
6 years ago (2014-12-19 00:17:04 UTC) #3
Habib Virji
https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations#newcode617 LayoutTests/TestExpectations:617: # Below crypto are temporary till chromium side changes ...
6 years ago (2014-12-19 00:22:17 UTC) #4
eroman
https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations#newcode617 LayoutTests/TestExpectations:617: # Below crypto are temporary till chromium side changes ...
6 years ago (2014-12-19 00:23:58 UTC) #5
Habib Virji
https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/811783004/diff/20001/LayoutTests/TestExpectations#newcode617 LayoutTests/TestExpectations:617: # Below crypto are temporary till chromium side changes ...
6 years ago (2014-12-19 00:29:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811783004/80001
6 years ago (2014-12-19 11:32:52 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-19 12:45:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187524

Powered by Google App Engine
This is Rietveld 408576698