Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 811763005: Ensure cancellation of animation timer in a detached state. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ensure cancellation of animation timer in a detached state. If an SVG element becomes detached from its document, its animations will be paused. Make sure this really cancels any "once" timers that might be scheduled. R=haraken,fs@opera.com BUG=3690 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188139

Patch Set 1 #

Patch Set 2 : Adjust comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. Following r187775, we've been running into some flaky crashers on the ...
5 years, 11 months ago (2015-01-09 06:31:45 UTC) #2
haraken
LGTM, but I want to have fs@ take another look.
5 years, 11 months ago (2015-01-09 07:06:32 UTC) #3
fs
lgtm
5 years, 11 months ago (2015-01-09 09:34:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811763005/20001
5 years, 11 months ago (2015-01-09 09:36:45 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 10:37:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188139

Powered by Google App Engine
This is Rietveld 408576698