Modify Bigint _mulAdd, _sqrAdd, _estQuotientDigit, and Montgomery _mulMod

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 1010 matching lines @@
   __ Bind(&done);
   // Restore CTX and return.
   __ popl(CTX);
   // Returning Object::null() is not required, since this method is private.
   __ ret();
 }
 
 
 void Intrinsifier::Bigint_mulAdd(Assembler* assembler) {
   // Pseudo code:
-  // static void _mulAdd(Uint32List x_digits, int xi,
-  //                     Uint32List m_digits, int i,
-  //                     Uint32List a_digits, int j, int n) {
+  // static int _mulAdd(Uint32List x_digits, int xi,
+  //                    Uint32List m_digits, int i,
+  //                    Uint32List a_digits, int j, int n) {
   //   uint32_t x = x_digits[xi >> 1];  // xi is Smi.
   //   if (x == 0 || n == 0) {
-  //     return;
+  //     return 1;
   //   }
   //   uint32_t* mip = &m_digits[i >> 1];  // i is Smi.
   //   uint32_t* ajp = &a_digits[j >> 1];  // j is Smi.
   //   uint32_t c = 0;
   //   SmiUntag(n);
   //   do {
   //     uint32_t mi = *mip++;
   //     uint32_t aj = *ajp;
   //     uint64_t t = x*mi + aj + c;  // 32-bit * 32-bit -> 64-bit.
   //     *ajp++ = low32(t);
   //     c = high32(t);
   //   } while (--n > 0);
   //   while (c != 0) {
   //     uint64_t t = *ajp + c;
   //     *ajp++ = low32(t);
   //     c = high32(t);  // c == 0 or 1.
   //   }
+  //   return 1;
   // }
 
   Label no_op;
   // EBX = x, no_op if x == 0
   __ movl(ECX, Address(ESP, 7 * kWordSize));  // x_digits
   __ movl(EAX, Address(ESP, 6 * kWordSize));  // xi is Smi
   __ movl(EBX, FieldAddress(ECX, EAX, TIMES_2, TypedData::data_offset()));
   __ testl(EBX, EBX);
   __ j(ZERO, &no_op, Assembler::kNearJump);
 
@@ skipping 69 matching lines @@
   __ addl(ESI, Immediate(Bigint::kBytesPerDigit));
   __ incl(Address(ESI, 0));  // c == 0 or 1
   __ j(CARRY, &propagate_carry_loop, Assembler::kNearJump);
 
   __ Bind(&done);
   __ Drop(1);  // n
   // Restore CTX and return.
   __ popl(CTX);
 
   __ Bind(&no_op);
-  // Returning Object::null() is not required, since this method is private.
+  __ movl(EAX, Immediate(Smi::RawValue(1)));  // One digit processed.
   __ ret();
 }
 
 
 void Intrinsifier::Bigint_sqrAdd(Assembler* assembler) {
   // Pseudo code:
-  // static void _sqrAdd(Uint32List x_digits, int i,
-  //                     Uint32List a_digits, int used) {
+  // static int _sqrAdd(Uint32List x_digits, int i,
+  //                    Uint32List a_digits, int used) {
   //   uint32_t* xip = &x_digits[i >> 1];  // i is Smi.
   //   uint32_t x = *xip++;
-  //   if (x == 0) return;
+  //   if (x == 0) return 1;
   //   uint32_t* ajp = &a_digits[i];  // j == 2*i, i is Smi.
   //   uint32_t aj = *ajp;
   //   uint64_t t = x*x + aj;
   //   *ajp++ = low32(t);
   //   uint64_t c = high32(t);
   //   int n = ((used - i) >> 1) - 1;  // used and i are Smi.
   //   while (--n >= 0) {
   //     uint32_t xi = *xip++;
   //     uint32_t aj = *ajp;
   //     uint96_t t = 2*x*xi + aj + c;  // 2-bit * 32-bit * 32-bit -> 65-bit.
   //     *ajp++ = low32(t);
   //     c = high64(t);  // 33-bit.
   //   }
   //   uint32_t aj = *ajp;
   //   uint64_t t = aj + c;  // 32-bit + 33-bit -> 34-bit.
   //   *ajp++ = low32(t);
   //   *ajp = high32(t);
+  //   return 1;
   // }
 
   // EDI = xip = &x_digits[i >> 1]
   __ movl(EDI, Address(ESP, 4 * kWordSize));  // x_digits
   __ movl(EAX, Address(ESP, 3 * kWordSize));  // i is Smi
   __ leal(EDI, FieldAddress(EDI, EAX, TIMES_2, TypedData::data_offset()));
 
   // EBX = x = *xip++, return if x == 0
   Label x_zero;
   __ movl(EBX, Address(EDI, 0));
@@ skipping 83 matching lines @@
 
   // *ajp++ = low32(t)
   // *ajp = high32(t)
   __ movl(Address(ESI, 0), EAX);
   __ movl(Address(ESI, Bigint::kBytesPerDigit), EDX);
 
   // Restore CTX and return.
   __ Drop(3);
   __ popl(CTX);
   __ Bind(&x_zero);
-  // Returning Object::null() is not required, since this method is private.
+  __ movl(EAX, Immediate(Smi::RawValue(1)));  // One digit processed.
   __ ret();
 }
 
 
 void Intrinsifier::Bigint_estQuotientDigit(Assembler* assembler) {
   // Pseudo code:
-  // static void _estQuotientDigit(Uint32List args, Uint32List digits, int i) {
-  //   uint32_t yt = args[_YT];  // _YT == 0.
+  // static int _estQuotientDigit(Uint32List args, Uint32List digits, int i) {
+  //   uint32_t yt = args[_YT];  // _YT == 1.
   //   uint32_t* dp = &digits[i >> 1];  // i is Smi.
   //   uint32_t dh = dp[0];  // dh == digits[i >> 1].
   //   uint32_t qd;
   //   if (dh == yt) {
   //     qd = DIGIT_MASK;
   //   } else {
   //     dl = dp[-1];  // dl == digits[(i - 1) >> 1].
   //     qd = dh:dl / yt;  // No overflow possible, because dh < yt.
   //   }
-  //   args[_QD] = qd;  // _QD == 1;
+  //   args[_QD] = qd;  // _QD == 2.
+  //   return 1;
   // }
 
   // EDI = args
   __ movl(EDI, Address(ESP, 3 * kWordSize));  // args
 
-  // ECX = yt = args[0]
-  __ movl(ECX, FieldAddress(EDI, TypedData::data_offset()));
+  // ECX = yt = args[1]
+  __ movl(ECX,
+          FieldAddress(EDI, TypedData::data_offset() + Bigint::kBytesPerDigit));
 
   // EBX = dp = &digits[i >> 1]
   __ movl(EBX, Address(ESP, 2 * kWordSize));  // digits
   __ movl(EAX, Address(ESP, 1 * kWordSize));  // i is Smi
   __ leal(EBX, FieldAddress(EBX, EAX, TIMES_2, TypedData::data_offset()));
 
   // EDX = dh = dp[0]
   __ movl(EDX, Address(EBX, 0));
 
   // EAX = qd = DIGIT_MASK = -1
   __ movl(EAX, Immediate(-1));
 
   // Return qd if dh == yt
   Label return_qd;
   __ cmpl(EDX, ECX);
   __ j(EQUAL, &return_qd, Assembler::kNearJump);
 
   // EAX = dl = dp[-1]
   __ movl(EAX, Address(EBX, -Bigint::kBytesPerDigit));
 
   // EAX = qd = dh:dl / yt = EDX:EAX / ECX
   __ divl(ECX);
 
   __ Bind(&return_qd);
-  // args[1] = qd
-  __ movl(FieldAddress(EDI, TypedData::data_offset() + Bigint::kBytesPerDigit),
+  // args[2] = qd
+  __ movl(FieldAddress(EDI,
+                       TypedData::data_offset() + 2*Bigint::kBytesPerDigit),
           EAX);
 
-  // Returning Object::null() is not required, since this method is private.
+  __ movl(EAX, Immediate(Smi::RawValue(1)));  // One digit processed.
   __ ret();
 }
 
 
 void Intrinsifier::Montgomery_mulMod(Assembler* assembler) {
   // Pseudo code:
-  // static void _mulMod(Uint32List args, Uint32List digits, int i) {
-  //   uint32_t rho = args[_RHO];  // _RHO == 0.
+  // static int _mulMod(Uint32List args, Uint32List digits, int i) {
+  //   uint32_t rho = args[_RHO];  // _RHO == 2.
   //   uint32_t d = digits[i >> 1];  // i is Smi.
   //   uint64_t t = rho*d;
-  //   args[_MU] = t mod DIGIT_BASE;  // _MU == 1.
+  //   args[_MU] = t mod DIGIT_BASE;  // _MU == 4.
+  //   return 1;
   // }
 
   // EDI = args
   __ movl(EDI, Address(ESP, 3 * kWordSize));  // args
 
-  // ECX = rho = args[0]
-  __ movl(ECX, FieldAddress(EDI, TypedData::data_offset()));
+  // ECX = rho = args[2]
+  __ movl(ECX,
+          FieldAddress(EDI,
+                       TypedData::data_offset() + 2*Bigint::kBytesPerDigit));
 
   // EAX = digits[i >> 1]
   __ movl(EBX, Address(ESP, 2 * kWordSize));  // digits
   __ movl(EAX, Address(ESP, 1 * kWordSize));  // i is Smi
   __ movl(EAX, FieldAddress(EBX, EAX, TIMES_2, TypedData::data_offset()));
 
   // EDX:EAX = t = rho*d
   __ mull(ECX);
 
-  // args[1] = t mod DIGIT_BASE = low32(t)
-  __ movl(FieldAddress(EDI, TypedData::data_offset() + Bigint::kBytesPerDigit),
+  // args[4] = t mod DIGIT_BASE = low32(t)
+  __ movl(FieldAddress(EDI,
+                       TypedData::data_offset() + 4*Bigint::kBytesPerDigit),
           EAX);
 
-  // Returning Object::null() is not required, since this method is private.
+  __ movl(EAX, Immediate(Smi::RawValue(1)));  // One digit processed.
   __ ret();
 }
 
 
 // Check if the last argument is a double, jump to label 'is_smi' if smi
 // (easy to convert to double), otherwise jump to label 'not_double_smi',
 // Returns the last argument in EAX.
 static void TestLastArgumentIsDouble(Assembler* assembler,
                                      Label* is_smi,
                                      Label* not_double_smi) {
@@ skipping 754 matching lines @@
                         Isolate::current_tag_offset());
   // Set return value to Isolate::current_tag_.
   __ movl(EAX, current_tag_addr);
   __ ret();
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32