Create AndroidCommandLineBackend to handle setting up cmdline args

tools/telemetry/telemetry/core/backends/android_app_backend.py

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 import time
 
 from telemetry.core import android_process
 from telemetry.core import util
 from telemetry.core import web_contents
 from telemetry.core.backends import adb_commands
 from telemetry.core.backends import app_backend
+from telemetry.core.backends import android_browser_backend_settings
+from telemetry.core.backends import android_command_line_backend
 
 
 class AndroidAppBackend(app_backend.AppBackend):
+
   def __init__(self, android_platform_backend, start_intent,
                is_app_ready_predicate=None):
     super(AndroidAppBackend, self).__init__(
         start_intent.package, android_platform_backend)
     self._default_process_name = start_intent.package
     self._start_intent = start_intent
     self._is_app_ready_predicate = is_app_ready_predicate
     self._is_running = False
     self._existing_processes_by_pid = {}
 
   @property
   def _adb(self):
     return self.platform_backend.adb
 
   def _IsAppReady(self):
     return self._is_app_ready_predicate(self.app)
 
   def Start(self):
     """Start an Android app and wait for it to finish launching.
 
     AppStory derivations can customize the wait-for-ready-state to wait
     for a more specific event if needed.
     """
-    # TODO(slamm): check if can use "blocking=True" instead of needing to sleep.
-    # If "blocking=True" does not work, switch sleep to "ps" check.
-    self._adb.device().StartActivity(self._start_intent, blocking=False)
-    util.WaitFor(self._IsAppReady, timeout=60)
+    webview_startup_args = self.GetWebviewStartupArgs()
+    backend_settings = android_browser_backend_settings.WebviewBackendSettings(
+        'android-webview')
+    with android_command_line_backend.AndroidCommandLineBackend(

[nednguyen, 2015/01/14 17:05:58]

This syntax is a little weird. Can we make a factory method that returns
AndroidCommandLineBackend so you can write it like:

with android_command_line_backend.SetupCommandLineArgs(..):
   ...

We can then make _AndroidCommandLineBackend a private class. 

[ariblue, 2015/01/14 21:19:26]

Done.

+        self._adb, backend_settings, webview_startup_args):
+      # TODO(slamm): check if can use "blocking=True" instead of needing to
+      # sleep. If "blocking=True" does not work, switch sleep to "ps" check.
+      self._adb.device().StartActivity(self._start_intent, blocking=False)
+      util.WaitFor(self._IsAppReady, timeout=60)
     self._is_running = True
 
   def Close(self):
     self._is_running = False
     self.platform_backend.KillApplication(self._start_intent.package)
 
   def IsAppRunning(self):
     return self._is_running
 
   def GetStandardOutput(self):
@@ skipping 21 matching lines @@
   def GetProcess(self, subprocess_name):
     assert subprocess_name.startswith(':')
     process_name = self._default_process_name + subprocess_name
     return self.GetProcesses(lambda n: n == process_name).pop()
 
   def GetWebViews(self):
     webviews = set()
     for process in self.GetProcesses():
       webviews.update(process.GetWebViews())
     return webviews
+
+  def GetWebviewStartupArgs(self):
+    args = []
+
+    # Turn on GPU benchmarking extension for all runs. The only side effect of
+    # the extension being on is that render stats are tracked. This is believed
+    # to be effectively free. And, by doing so here, it avoids us having to
+    # programmatically inspect a pageset's actions in order to determine if it
+    # might eventually scroll.
+    args.append('--enable-gpu-benchmarking')
+
+    return args