SIMPLE_GM generates less code

SIMPLE_GM generates less code

Committed: https://skia.googlesource.com/skia/+/f62c63490f0cba13eaadce720b58a95720b2df86

[hal.canary, 2015-01-12 22:18:07]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-01-12 22:18:08]

ptal

[mtklein, 2015-01-12 22:55:05]

https://codereview.chromium.org/811703005/diff/1/gm/gm.h
File gm/gm.h (right):

https://codereview.chromium.org/811703005/diff/1/gm/gm.h#newcode29
gm/gm.h:29: void SK_MACRO_CONCAT(NAME, _GM)(SkCanvas* CANVAS);                 
\
Make this function static?

[hal.canary, 2015-01-12 23:08:10]

https://codereview.chromium.org/811703005/diff/1/gm/gm.h
File gm/gm.h (right):

https://codereview.chromium.org/811703005/diff/1/gm/gm.h#newcode29
gm/gm.h:29: void SK_MACRO_CONCAT(NAME, _GM)(SkCanvas* CANVAS);                 
\
On 2015/01/12 22:55:05, mtklein wrote:
> Make this function static?

Done.

[mtklein, 2015-01-12 23:13:36]

lgtm

https://codereview.chromium.org/811703005/diff/20001/gm/gm.h
File gm/gm.h (right):

https://codereview.chromium.org/811703005/diff/20001/gm/gm.h#newcode137
gm/gm.h:137: SimpleGM(const SkString& name,
Looks like you can simplify a little further by delaying the const char* ->
SkString conversion until here, calling SkString(const char*) rather than
SkString(const SkString&).

[hal.canary, 2015-01-12 23:17:42]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-01-12 23:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/811703005/20001

[commit-bot: I haz the power, 2015-01-12 23:27:55]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f62c63490f0cba13eaadce720b58a95720b2df86