Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 811703002: [wip] low overhead icc for jpeg

Created:
6 years ago by Noel Gordon
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wip] low overhead icc for jpeg BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -0 lines) Patch
M third_party/iccjpeg/iccjpeg.h View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/iccjpeg/iccjpeg.c View 1 chunk +112 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Noel Gordon
On 2016/03/31 14:55:48, Yoav Weiss wrote: Interested in this?
4 years, 8 months ago (2016-04-04 03:32:35 UTC) #2
Yoav Weiss
On 2016/04/04 03:32:35, noel gordon wrote: > On 2016/03/31 14:55:48, Yoav Weiss wrote: > > ...
4 years, 8 months ago (2016-04-04 07:07:25 UTC) #3
Noel Gordon
Thank you, I'd like to see this move forward standards-wise; I have various google-internal teams ...
4 years, 8 months ago (2016-04-04 08:33:13 UTC) #4
Noel Gordon
4 years, 8 months ago (2016-04-04 08:37:54 UTC) #5
Some other thoughts, just looking over this code ...

https://codereview.chromium.org/811703002/diff/1/third_party/iccjpeg/iccjpeg.c
File third_party/iccjpeg/iccjpeg.c (right):

https://codereview.chromium.org/811703002/diff/1/third_party/iccjpeg/iccjpeg....
third_party/iccjpeg/iccjpeg.c:267: * explicit profile (ICC_PROFILE markers), but
not both.
Another option here might be to allow both markers, but make one trump the other
if both are given.

https://codereview.chromium.org/811703002/diff/1/third_party/iccjpeg/iccjpeg....
third_party/iccjpeg/iccjpeg.c:354: *intent = GETJOCTET(src[1]);
Should we write the following here?

  *intent = GETJOCTET(src[1]) & 3;

Powered by Google App Engine
This is Rietveld 408576698