Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811653004: [turbofan] Improve typed lowering of JSBitwiseAnd. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve typed lowering of JSBitwiseAnd. TEST=unittests R=jarin@chromium.org Committed: https://crrev.com/284e1108182995abe85f580bc813d26491642b8c Cr-Commit-Position: refs/heads/master@{#26046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -13 lines) Patch
M src/compiler/js-typed-lowering.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 7 chunks +62 lines, -13 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-14 06:17:11 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-14 06:18:32 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-14 07:39:27 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 284e1108182995abe85f580bc813d26491642b8c (presubmit successful).
5 years, 11 months ago (2015-01-14 07:40:41 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/284e1108182995abe85f580bc813d26491642b8c Cr-Commit-Position: refs/heads/master@{#26046}
5 years, 11 months ago (2015-01-14 07:40:45 UTC) #7
Benedikt Meurer
5 years, 11 months ago (2015-01-14 09:06:10 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/795833006/ by bmeurer@chromium.org.

The reason for reverting is: Breaks SQLite.

Powered by Google App Engine
This is Rietveld 408576698