Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 811603003: Add a console control handler chrome_watcher.dll. (Closed)

Created:
6 years ago by Sigurður Ásgeirsson
Modified:
6 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@base_process
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a console control handler chrome_watcher.dll. This will hopefully allow conclusively answering whether the problem is at ExitWindows-time. R=erikwright@chromium.org, mpearson@chromium.org BUG=412384 Committed: https://crrev.com/d497a1a3857023c55ae421f11208d38e78795b58 Cr-Commit-Position: refs/heads/master@{#309201}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only wait for logoff on unexpected exit codes. #

Total comments: 16

Patch Set 3 : Address Greg's nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -6 lines) Patch
M chrome/chrome_watcher/chrome_watcher_main.cc View 1 2 5 chunks +54 lines, -1 line 0 comments Download
M components/browser_watcher/exit_code_watcher_win.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M components/browser_watcher/exit_code_watcher_win.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
Sigurður Ásgeirsson
PTAL Mark, apologies for another ugly histogram, I promise to rip this out ASAP.
6 years ago (2014-12-18 20:57:35 UTC) #1
Sigurður Ásgeirsson
On 2014/12/18 20:57:35, Sigurður Ásgeirsson wrote: > PTAL > > Mark, apologies for another ugly ...
6 years ago (2014-12-18 21:09:06 UTC) #2
Sigurður Ásgeirsson
On 2014/12/18 20:57:35, Sigurður Ásgeirsson wrote: > PTAL > > Mark, apologies for another ugly ...
6 years ago (2014-12-18 21:09:08 UTC) #3
erikwright (departed)
Greg, this CL would cause the browser watcher to wait 30s after Chrome (browser) exits ...
6 years ago (2014-12-18 21:45:08 UTC) #5
Sigurður Ásgeirsson
https://codereview.chromium.org/811603003/diff/1/chrome/chrome_watcher/chrome_watcher_main.cc File chrome/chrome_watcher/chrome_watcher_main.cc (right): https://codereview.chromium.org/811603003/diff/1/chrome/chrome_watcher/chrome_watcher_main.cc#newcode90 chrome/chrome_watcher/chrome_watcher_main.cc:90: data.handler_done.TimedWait(base::TimeDelta::FromSeconds(30)); On 2014/12/18 21:45:07, erikwright wrote: > This wait ...
6 years ago (2014-12-18 21:50:33 UTC) #6
Mark P
histograms.xml lgtm rubberstamp
6 years ago (2014-12-18 22:19:35 UTC) #7
Sigurður Ásgeirsson
Amended to only wait on unexpected exit codes. I don't want to take a dependency ...
6 years ago (2014-12-18 22:51:24 UTC) #8
grt (UTC plus 2)
Just to confirm: this will no longer block uninstall, yes? https://codereview.chromium.org/811603003/diff/20001/chrome/chrome_watcher/chrome_watcher_main.cc File chrome/chrome_watcher/chrome_watcher_main.cc (right): https://codereview.chromium.org/811603003/diff/20001/chrome/chrome_watcher/chrome_watcher_main.cc#newcode27 ...
6 years ago (2014-12-19 01:57:35 UTC) #9
Sigurður Ásgeirsson
Thanks - this will no longer block uninstall, so long as running Chrome instances exit ...
6 years ago (2014-12-19 13:40:58 UTC) #10
erikwright (departed)
LGTM.
6 years ago (2014-12-19 14:17:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811603003/40001
6 years ago (2014-12-19 15:06:25 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-19 15:21:20 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-19 15:22:44 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d497a1a3857023c55ae421f11208d38e78795b58
Cr-Commit-Position: refs/heads/master@{#309201}

Powered by Google App Engine
This is Rietveld 408576698